Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Tom Tromey <tom@tromey.com>,  gdb-patches@sourceware.org
Subject: Re: [PATCH 3/5] Fix weird quoting in stap-probe.c
Date: Thu, 03 Sep 2026 10:04:59 -0600	[thread overview]
Message-ID: <87y0di2udw.fsf@tromey.com> (raw)
In-Reply-To: <86mrudwj97.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 23 Aug 2026 07:31:00 +0300")

>>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:

>> warning (_("unrecognized bitness %s%c' for probe `%s'"),
>> got_minus ? "`-" : "`", *cur,
>> 
>> Here the leading ` is not part of the format string.  I found this odd
>> and so I split this fix out into its own patch.

Eli> This changes the quoting style of "-7" and the like.  As the test
Eli> suite shows, it was previously quoted as `-7'.  Is there a good reason
Eli> for this change?  I'm not sure I understand what is weird about this
Eli> quoting or ` not being part of the format string.  Is this just a
Eli> style-preference thing?

There are two parts to this particular patch.

First, putting the opening quote into an argument string, rather than in
the format string, is a weird choice, IMO.

Second, I am slowly changing gdb to standardize on "..." quoting.
Removing `...' quoting is the first part of this.

Tom

  parent reply	other threads:[~2026-09-03 16:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-22 20:30 [PATCH 0/5] Remove `...' and related forms of quoting from gdb Tom Tromey
2026-08-22 20:30 ` [PATCH 1/5] Change `...'-style quoting in gdbsupport Tom Tromey
2026-08-22 20:30 ` [PATCH 2/5] Change `...'-style quoting in gdbserver Tom Tromey
2026-08-22 20:30 ` [PATCH 3/5] Fix weird quoting in stap-probe.c Tom Tromey
2026-08-23  4:31   ` Eli Zaretskii
2026-08-24 18:09     ` Tom de Vries
2026-09-03 16:04     ` Tom Tromey [this message]
2026-08-22 20:30 ` [PATCH 4/5] Change `...'-style quoting in gdb Tom Tromey
2026-08-22 20:30 ` [PATCH 5/5] Fix styling in a few messages Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y0di2udw.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox