From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: [PATCH 2/5] Change `...'-style quoting in gdbserver
Date: Sat, 22 Aug 2026 14:30:04 -0600 [thread overview]
Message-ID: <20260822-no-backquotes-in-strings-v1-2-0b035ad036a3@tromey.com> (raw)
In-Reply-To: <20260822-no-backquotes-in-strings-v1-0-0b035ad036a3@tromey.com>
This changes spots in gdbserver that use `...'-style quoting to use
double quotes instead.
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34044
---
gdb/testsuite/gdb.server/no-thread-db.exp | 2 +-
gdbserver/thread-db.cc | 4 ++--
gdbserver/tracepoint.cc | 12 ++++++------
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/gdb/testsuite/gdb.server/no-thread-db.exp b/gdb/testsuite/gdb.server/no-thread-db.exp
index 9cbe962bc3c..f1d91e728be 100644
--- a/gdb/testsuite/gdb.server/no-thread-db.exp
+++ b/gdb/testsuite/gdb.server/no-thread-db.exp
@@ -49,7 +49,7 @@ gdbserver_run ""
# Force gdbserver to fail to load libthread_db.
gdb_test "monitor set libthread-db-search-path ${unresolvable_thread_db_path}" \
- "libthread-db-search-path set to `${unresolvable_thread_db_path}'" \
+ "libthread-db-search-path set to \"${unresolvable_thread_db_path}\"" \
"libthread-db is now unresolvable"
# Continue past tls assignment to make sure tls storage is allocated.
diff --git a/gdbserver/thread-db.cc b/gdbserver/thread-db.cc
index af39a58154e..fd3928b7d2c 100644
--- a/gdbserver/thread-db.cc
+++ b/gdbserver/thread-db.cc
@@ -855,9 +855,9 @@ thread_db_handle_monitor_command (const char *mon)
cp = LIBTHREAD_DB_SEARCH_PATH;
libthread_db_search_path = xstrdup (cp);
- monitor_output ("libthread-db-search-path set to `");
+ monitor_output ("libthread-db-search-path set to \"");
monitor_output (libthread_db_search_path);
- monitor_output ("'\n");
+ monitor_output ("\"\n");
return 1;
}
diff --git a/gdbserver/tracepoint.cc b/gdbserver/tracepoint.cc
index 593dca65f76..e1226bf266e 100644
--- a/gdbserver/tracepoint.cc
+++ b/gdbserver/tracepoint.cc
@@ -249,7 +249,7 @@ tracepoint_look_up_symbols (void)
if (look_up_one_symbol (symbol_list[i].name, addrp, 1) == 0)
{
- threads_debug_printf ("symbol `%s' not found", symbol_list[i].name);
+ threads_debug_printf ("symbol \"%s\" not found", symbol_list[i].name);
return;
}
}
@@ -5170,23 +5170,23 @@ fast_tracepoint_collecting (CORE_ADDR thread_area,
if (read_inferior_data_pointer (ipa_sym_addrs.addr_gdb_jump_pad_buffer,
&ipa_gdb_jump_pad_buffer))
{
- internal_error ("error extracting `gdb_jump_pad_buffer'");
+ internal_error ("error extracting \"gdb_jump_pad_buffer\"");
}
if (read_inferior_data_pointer (ipa_sym_addrs.addr_gdb_jump_pad_buffer_end,
&ipa_gdb_jump_pad_buffer_end))
{
- internal_error ("error extracting `gdb_jump_pad_buffer_end'");
+ internal_error ("error extracting \"gdb_jump_pad_buffer_end\"");
}
if (read_inferior_data_pointer (ipa_sym_addrs.addr_gdb_trampoline_buffer,
&ipa_gdb_trampoline_buffer))
{
- internal_error ("error extracting `gdb_trampoline_buffer'");
+ internal_error ("error extracting \"gdb_trampoline_buffer\"");
}
if (read_inferior_data_pointer (ipa_sym_addrs.addr_gdb_trampoline_buffer_end,
&ipa_gdb_trampoline_buffer_end))
{
- internal_error ("error extracting `gdb_trampoline_buffer_end'");
+ internal_error ("error extracting \"gdb_trampoline_buffer_end\"");
}
if (ipa_gdb_jump_pad_buffer <= stop_pc
@@ -5768,7 +5768,7 @@ download_tracepoint (struct tracepoint *tpoint)
+ offsetof (struct tracepoint, next),
&tp_prev_target_next_addr))
{
- internal_error ("error reading `tp_prev->next'");
+ internal_error ("error reading \"tp_prev->next\"");
}
/* tpoint->next = tp_prev->next */
--
2.49.0
next prev parent reply other threads:[~2026-08-22 20:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-22 20:30 [PATCH 0/5] Remove `...' and related forms of quoting from gdb Tom Tromey
2026-08-22 20:30 ` [PATCH 1/5] Change `...'-style quoting in gdbsupport Tom Tromey
2026-08-22 20:30 ` Tom Tromey [this message]
2026-08-22 20:30 ` [PATCH 3/5] Fix weird quoting in stap-probe.c Tom Tromey
2026-08-23 4:31 ` Eli Zaretskii
2026-08-24 18:09 ` Tom de Vries
2026-08-22 20:30 ` [PATCH 4/5] Change `...'-style quoting in gdb Tom Tromey
2026-08-22 20:30 ` [PATCH 5/5] Fix styling in a few messages Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260822-no-backquotes-in-strings-v1-2-0b035ad036a3@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox