From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/5] Fix weird quoting in stap-probe.c
Date: Sun, 23 Aug 2026 07:31:00 +0300 [thread overview]
Message-ID: <86mrudwj97.fsf@gnu.org> (raw)
In-Reply-To: <20260822-no-backquotes-in-strings-v1-3-0b035ad036a3@tromey.com> (message from Tom Tromey on Sat, 22 Aug 2026 14:30:05 -0600)
> From: Tom Tromey <tom@tromey.com>
> Date: Sat, 22 Aug 2026 14:30:05 -0600
> Cc: Tom Tromey <tom@tromey.com>
>
> I found some code in stap-probe.c that split the quoting in a strange
> way:
>
> warning (_("unrecognized bitness %s%c' for probe `%s'"),
> got_minus ? "`-" : "`", *cur,
>
> Here the leading ` is not part of the format string. I found this odd
> and so I split this fix out into its own patch.
This changes the quoting style of "-7" and the like. As the test
suite shows, it was previously quoted as `-7'. Is there a good reason
for this change? I'm not sure I understand what is weird about this
quoting or ` not being part of the format string. Is this just a
style-preference thing?
next prev parent reply other threads:[~2026-08-23 4:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-22 20:30 [PATCH 0/5] Remove `...' and related forms of quoting from gdb Tom Tromey
2026-08-22 20:30 ` [PATCH 1/5] Change `...'-style quoting in gdbsupport Tom Tromey
2026-08-22 20:30 ` [PATCH 2/5] Change `...'-style quoting in gdbserver Tom Tromey
2026-08-22 20:30 ` [PATCH 3/5] Fix weird quoting in stap-probe.c Tom Tromey
2026-08-23 4:31 ` Eli Zaretskii [this message]
2026-08-24 18:09 ` Tom de Vries
2026-08-22 20:30 ` [PATCH 4/5] Change `...'-style quoting in gdb Tom Tromey
2026-08-22 20:30 ` [PATCH 5/5] Fix styling in a few messages Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86mrudwj97.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox