From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8/HsK6h3imrbGDgAWB0awg (envelope-from ) for ; Sun, 23 Aug 2026 00:31:36 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=Y2k6toOQ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 9D2D21E09B; Sun, 23 Aug 2026 00:31:36 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 38E081E09B for ; Sun, 23 Aug 2026 00:31:34 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D95264B9DB60 for ; Sun, 23 Aug 2026 04:31:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D95264B9DB60 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=Y2k6toOQ Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 2BA574BA901D for ; Sun, 23 Aug 2026 04:31:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2BA574BA901D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2BA574BA901D Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787459470; cv=none; b=HU+3bof/VVSbgTLuG4zAyiD1v8th1KqELrdHm4fAltB5g1Q744S63nhkO5HL9mXcoMD4HXGkhnOKM1gMEmH0JCc9nqkAO8PFrejoJ9DeHrKXl6G06vudZQVaD4PtfzsofgvZc5OeBsxBnCNztmphiV0gaWgRD045z+gtq47F2FU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787459470; c=relaxed/simple; bh=klURuxBbnLCIP0zr2iwsAhyIiAPOGdTqX7O6VGRal2k=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=sTXX9Et7ERF7+t9HMtycFf6jUnZe0Y646ndXFizq83ytu0mhPT8SoteaUT9H5x7F7eJg3jq8VbYMw8r1uCPMY2sXmIWab/MoYA8zENrntmjaf1Rjz/W3c4+1YaJ8fy1EPzdHFV7oZ+tJHKNE8RVEPbaQaccjhVAptZSgy8pIa48= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=Y2k6toOQ DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2BA574BA901D Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wxzrN-0000bJ-6Q; Sun, 23 Aug 2026 00:31:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=VtPSvvwylQUeBZ2oPprti8d/4dhaZZNOlDIPVScZ2aE=; b=Y2k6toOQ0W6j zSTVtuv3ViyAnTEenOLa4HzBZIXbsMUV5fTBnES+X1sa+DxxvjTpgIrd89NYVCqfbx7Yo2SzCAr45 CFOc8Xt+9c/onml+hFRWUwlLKg+S8pSsZS0oMlasGqP3Kz0qhiNo23jGxRylIrj+Mkvi8sEzclEqo qv7WthR5cgS7IARx5ePNvRZXq+ht9+RzkKks8sSOyT2P2mCAsMkMiUStQEHNHGz0+m6sBqcdps7Lb z3FC6BDPr0MKB9Cpn0wtRP5QkYBajuM0xFeZQ1Guvb4EsT4BTUIDdfji4q1j4ppjFcDL4o4QrGiVQ xw4jkPeRMq0Hy/4XqM1fIw==; Date: Sun, 23 Aug 2026 07:31:00 +0300 Message-Id: <86mrudwj97.fsf@gnu.org> From: Eli Zaretskii To: Tom Tromey Cc: gdb-patches@sourceware.org In-Reply-To: <20260822-no-backquotes-in-strings-v1-3-0b035ad036a3@tromey.com> (message from Tom Tromey on Sat, 22 Aug 2026 14:30:05 -0600) Subject: Re: [PATCH 3/5] Fix weird quoting in stap-probe.c References: <20260822-no-backquotes-in-strings-v1-0-0b035ad036a3@tromey.com> <20260822-no-backquotes-in-strings-v1-3-0b035ad036a3@tromey.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org > From: Tom Tromey > Date: Sat, 22 Aug 2026 14:30:05 -0600 > Cc: Tom Tromey > > I found some code in stap-probe.c that split the quoting in a strange > way: > > warning (_("unrecognized bitness %s%c' for probe `%s'"), > got_minus ? "`-" : "`", *cur, > > Here the leading ` is not part of the format string. I found this odd > and so I split this fix out into its own patch. This changes the quoting style of "-7" and the like. As the test suite shows, it was previously quoted as `-7'. Is there a good reason for this change? I'm not sure I understand what is weird about this quoting or ` not being part of the format string. Is this just a style-preference thing?