From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: [PATCH 1/5] Change `...'-style quoting in gdbsupport
Date: Sat, 22 Aug 2026 14:30:03 -0600 [thread overview]
Message-ID: <20260822-no-backquotes-in-strings-v1-1-0b035ad036a3@tromey.com> (raw)
In-Reply-To: <20260822-no-backquotes-in-strings-v1-0-0b035ad036a3@tromey.com>
This changes spots in gdbsupport that use `...'-style quoting to use
double quotes instead. Some spots also use the `...` style; these are
also changed.
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34044
---
gdbsupport/agent.cc | 2 +-
gdbsupport/event-loop.cc | 4 ++--
gdbsupport/format.cc | 4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/gdbsupport/agent.cc b/gdbsupport/agent.cc
index 44b6fcdcf5c..92fcf884f73 100644
--- a/gdbsupport/agent.cc
+++ b/gdbsupport/agent.cc
@@ -97,7 +97,7 @@ agent_look_up_symbols (void *arg)
if (find_minimal_symbol_address (symbol_list[i].name, addrp,
objfile) != 0)
{
- DEBUG_AGENT ("symbol `%s' not found\n", symbol_list[i].name);
+ DEBUG_AGENT ("symbol \"%s\" not found\n", symbol_list[i].name);
return -1;
}
}
diff --git a/gdbsupport/event-loop.cc b/gdbsupport/event-loop.cc
index c6e1b5b4634..7ac899dc38d 100644
--- a/gdbsupport/event-loop.cc
+++ b/gdbsupport/event-loop.cc
@@ -521,7 +521,7 @@ handle_file_event (file_handler *file_ptr, int ready_mask)
if (mask & POLLERR)
warning (_("Error detected on fd %d"), file_ptr->fd);
if (mask & POLLNVAL)
- warning (_("Invalid or non-`poll'able fd %d"),
+ warning (_("Invalid or non-\"poll\"able fd %d"),
file_ptr->fd);
file_ptr->error = 1;
}
@@ -546,7 +546,7 @@ handle_file_event (file_handler *file_ptr, int ready_mask)
if (mask != 0)
{
event_loop_ui_debug_printf (file_ptr->is_ui,
- "invoking fd file handler `%s`",
+ "invoking fd file handler \"%s\"",
file_ptr->name.c_str ());
file_ptr->proc (file_ptr->error, file_ptr->client_data);
}
diff --git a/gdbsupport/format.cc b/gdbsupport/format.cc
index 43995edf453..35e61e43698 100644
--- a/gdbsupport/format.cc
+++ b/gdbsupport/format.cc
@@ -359,10 +359,10 @@ format_pieces::format_pieces (const char **arg, bool gdb_extensions,
break;
case '*':
- error (_("`*' not supported for precision or width in printf"));
+ error (_("\"*\" not supported for precision or width in printf"));
case 'n':
- error (_("Format specifier `n' not supported in printf"));
+ error (_("Format specifier \"n\" not supported in printf"));
case '\0':
error (_("Incomplete format specifier at end of format string"));
--
2.49.0
next prev parent reply other threads:[~2026-08-22 20:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-22 20:30 [PATCH 0/5] Remove `...' and related forms of quoting from gdb Tom Tromey
2026-08-22 20:30 ` Tom Tromey [this message]
2026-08-22 20:30 ` [PATCH 2/5] Change `...'-style quoting in gdbserver Tom Tromey
2026-08-22 20:30 ` [PATCH 3/5] Fix weird quoting in stap-probe.c Tom Tromey
2026-08-23 4:31 ` Eli Zaretskii
2026-08-24 18:09 ` Tom de Vries
2026-08-22 20:30 ` [PATCH 4/5] Change `...'-style quoting in gdb Tom Tromey
2026-08-22 20:30 ` [PATCH 5/5] Fix styling in a few messages Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260822-no-backquotes-in-strings-v1-1-0b035ad036a3@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox