From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id GwUmH82amWpcyiUAWB0awg (envelope-from ) for ; Thu, 03 Sep 2026 12:05:33 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=AjsJUhj8; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 463921E033; Thu, 03 Sep 2026 12:05:33 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id F14CD1E033 for ; Thu, 03 Sep 2026 12:05:31 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 77A5E4BAE7FC for ; Thu, 3 Sep 2026 16:05:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 77A5E4BAE7FC Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=AjsJUhj8 Received: from omta038.useast.a.cloudfilter.net (omta038.useast.a.cloudfilter.net [44.202.169.37]) by sourceware.org (Postfix) with ESMTPS id 433C64BA903E for ; Thu, 3 Sep 2026 16:05:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 433C64BA903E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 433C64BA903E Authentication-Results: sourceware.org; arc=none smtp.remote-ip=44.202.169.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788451504; cv=none; b=Z23oyromiHFXd4nkT7EWERjf+4Kq8SrtxBOaIicoQEmaQMvg9StLKgd0FxApah3sDvslRKnnhBJEkxvIVbnTXk60MuabhXdYoOd4KiWtdaz6aRYCKKRV/7tgUVcUgtiWUnEz/TMjqd0XE4QTUzuVjHRZE34RJ+145ZXrdAw/b/0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788451504; c=relaxed/simple; bh=dpCbh5dl+IE8H9RUeJDL2a7VdFCx3Z0fu66aIDCNtkA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=t7hOIDa414Ekiq7yJy/m+5zeh2SNapyFzweyH5cTsVnj5YoXOXX5FgSY1qrxJQtkYlyIemtVMTmarC0uQJOZy3VcvPhve6wHk0IkwxMgEfu3MdJv2bjzn9l8yEYiSUHpv8rwNSMIjNOKgMBv7+jsOIPXTD8dgsoDnMdtxep/D24= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=AjsJUhj8 reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 433C64BA903E Received: from eig-obgw-5007b.ext.cloudfilter.net ([10.0.29.167]) by cmsmtp with ESMTPS id 274Dxi1B8JFmF29vyxH9tU; Thu, 03 Sep 2026 16:05:02 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 29vwxFV4DbQ0n29vxxXHi6; Thu, 03 Sep 2026 16:05:01 +0000 X-Authority-Analysis: v=2.4 cv=S4XZwJsP c=1 sm=1 tr=0 ts=6a999aad a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=VdqzKS8jKosA:10 a=ItBw4LHWJt0A:10 a=mDV3o1hIAAAA:8 a=t2IPGsGb751ZDMkDXQcA:9 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=FSXsv00WQNo5JEOVdk/FKp5QKi2MF/JU9aw/XSkk6Wk=; b=AjsJUhj8bZOF2XtK4f+RtTvXJX j7cBxUO8//q4mOQQdcY6V62nLoC8oanmr0nzL/f+XjfJuWhyl88RAWycaX82BYKm2W3/e9Jk9LiA0 UdLjNJu87TmvBEEB1W5vQeO91; Received: from 97-122-117-2.hlrn.qwest.net ([97.122.117.2]:43116 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.99.5) (envelope-from ) id 1x29vw-00000003rmL-2CI8; Thu, 03 Sep 2026 10:05:00 -0600 From: Tom Tromey To: Eli Zaretskii Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 3/5] Fix weird quoting in stap-probe.c In-Reply-To: <86mrudwj97.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 23 Aug 2026 07:31:00 +0300") References: <20260822-no-backquotes-in-strings-v1-0-0b035ad036a3@tromey.com> <20260822-no-backquotes-in-strings-v1-3-0b035ad036a3@tromey.com> <86mrudwj97.fsf@gnu.org> X-Attribution: Tom Date: Thu, 03 Sep 2026 10:04:59 -0600 Message-ID: <87y0di2udw.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.117.2 X-Source-L: No X-Exim-ID: 1x29vw-00000003rmL-2CI8 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-117-2.hlrn.qwest.net (bapiya) [97.122.117.2]:43116 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfNDpLBUNcQdO+RDKfkoLWAuAnSniir2j8lzApqAHJdETV//A0ae4u7ddOwaGewQlQa0cbGMVHWY3OPJLo4K+G6ua+VT5RSj4xT7I+xdHKMQHM6KomhwS +PpznyVDCCv/vHCcI/TA2fPddOfoESNvTEnOLt3OFtXCQza5a4kZn7gGNvW0GI2aE9T49RCe3OsO4NtY3gFKxauAQTd2FBNkMGc= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Eli" == Eli Zaretskii writes: >> warning (_("unrecognized bitness %s%c' for probe `%s'"), >> got_minus ? "`-" : "`", *cur, >> >> Here the leading ` is not part of the format string. I found this odd >> and so I split this fix out into its own patch. Eli> This changes the quoting style of "-7" and the like. As the test Eli> suite shows, it was previously quoted as `-7'. Is there a good reason Eli> for this change? I'm not sure I understand what is weird about this Eli> quoting or ` not being part of the format string. Is this just a Eli> style-preference thing? There are two parts to this particular patch. First, putting the opening quote into an argument string, rather than in the format string, is a weird choice, IMO. Second, I am slowly changing gdb to standardize on "..." quoting. Removing `...' quoting is the first part of this. Tom