Re: [PATCH] gdb, amd-dbgapi-target: use PRIu64 and PRIu32

[Tom Tromey <tom@tromey.com>]

>>>>> "Pedro" == Pedro Alves <pedro@palves.net> writes:

Pedro> Agreed.  And it's also a portability hazard, like other printf
Pedro> formats, as you have to match the printf format to the type of
Pedro> the variable.

Yeah, I meant to point this out as well.

For pulongest you really only need to know whether the type is signed;
and we could easily fix that if we cared to.

Pedro> (std::cout << ... << ... tends to be unreadable too IMHO, but we don't use that, thankfully).

I thought about this for ui_file but meh.  It's kind of i18n-unfriendly
as well.

Pedro> {fmt} would be better, but that's either a new external dependency, or 
Pedro> bump to c++20 for std::format, or c++23 for widely available std::print.

I looked into this but it is also i18n-unfriendly, since as far as I can
tell it requires you to either give up gettext or give up any sort of
format checking.  For printf this isn't an issue because GCC understands
that _() is "transparent".

Also of course switching to fmt would be a colossal effort.

Tom