From: Tom Tromey <tom@tromey.com>
To: Lancelot SIX <Lancelot.Six@amd.com>
Cc: Tankut Baris Aktemur <tankutbaris.aktemur@amd.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb, amd-dbgapi-target: use PRIu64 and PRIu32
Date: Thu, 02 Jul 2026 14:15:06 -0600 [thread overview]
Message-ID: <87echlf8s5.fsf@tromey.com> (raw)
In-Reply-To: <6ae6dd2b-9577-4711-a0c8-93663a28e997@amd.com> (Lancelot SIX's message of "Wed, 1 Jul 2026 16:16:57 +0100")
>>>>> Lancelot SIX <Lancelot.Six@amd.com> writes:
> Hi,
> Doesn't GDB have an implicit habit/policy not to use the PRI??? macros?
> I do not mind them in amd-dbgapi-target.c, but want to make sure
> global maintainers are fine with this.
> I guess the alternative is to use pulongest + %s instead of PRIu64.
> i.e. something like this:
> str += (agent_id != AMD_DBGAPI_AGENT_NONE
> ? string_printf (" %s", pulongest (agent_id.handle))
> : "?");
I don't know if it's a policy exactly, but personally I prefer pulongest
et al, since I find the PRI* macros pretty ugly and unreadable.
Tom
next prev parent reply other threads:[~2026-07-02 20:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-01 14:28 Tankut Baris Aktemur
2026-07-01 15:16 ` Lancelot SIX
2026-07-01 16:56 ` Aktemur, Baris
2026-07-02 20:15 ` Tom Tromey [this message]
2026-07-03 12:59 ` Simon Marchi
2026-07-03 13:47 ` Pedro Alves
2026-07-03 18:15 ` Tom Tromey
2026-07-03 19:18 ` Pedro Alves
2026-07-03 19:22 ` Pedro Alves
2026-07-03 11:03 ` [PATCH v2] gdb, amd-dbgapi-target: use pulongest to print id handles Tankut Baris Aktemur
2026-07-03 11:22 ` Lancelot SIX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87echlf8s5.fsf@tromey.com \
--to=tom@tromey.com \
--cc=Lancelot.Six@amd.com \
--cc=gdb-patches@sourceware.org \
--cc=tankutbaris.aktemur@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox