Re: [PATCH] Merge handle_inferior_event and handle_inferior_event_1

[Sergio Durigan Junior <sergiodj@redhat.com>]

On Tuesday, March 26 2019, Tom Tromey wrote:

>>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
>
>>> Also, if a crash can occur during value destruction like this, then I
>>> think it must indicate a bug somewhere else, like invalid reference
>>> counting somewhere.
>
> Sergio> That's a good point, yeah.  I can try investigating more.
>
> Maybe one idea would be to back out my patch and then run the failing
> test under valgrind.

Thanks.

> Sergio> Having said that, I think the patch is simple enough to be safely
> Sergio> backportable to 8.3, and it doesn't really break anything (in fact, as
> Sergio> Pedro mentioned, it makes things more correct, because now we're sure
> Sergio> that we will destroy the objects if an exception is thrown), so IMHO
> Sergio> there's no downside to it.  WDYT?
>
> I agree.

Thanks, Tom.  I created
<https://sourceware.org/bugzilla/show_bug.cgi?id=24391>.  Would you like
me to go ahead and backport the patch to the 8.3 branch, or do you want
to do that?

Thanks,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/