From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Merge handle_inferior_event and handle_inferior_event_1
Date: Fri, 22 Mar 2019 00:01:00 -0000 [thread overview]
Message-ID: <87mulnkcab.fsf@redhat.com> (raw)
In-Reply-To: <87r2azkhmq.fsf@redhat.com> (Sergio Durigan Junior's message of "Thu, 21 Mar 2019 18:05:49 -0400")
On Thursday, March 21 2019, I wrote:
> On Wednesday, March 20 2019, Tom Tromey wrote:
>
>> I noticed that handle_inferior_event is just a small wrapper that
>> frees the value chain. This patch replaces it with a
>> scoped_value_mark, reducing the number of lines of code here.
>>
>> Regression tested on x86-64 Fedora 29.
>
> A few days ago (March 18th) a user reported a bug against Fedora GDB:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1690120
>
> And, after hours and hours investigating this, I found that your commit
> actually fixes it. Not sure if it was intended or not, but what a
> coincidence...
Of course, something I'd also like to ask is: do you think this change
is trivial enough to be included in the 8.3 release? I'd like to see it
happen. I can create a bug if needed.
Thanks,
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
next prev parent reply other threads:[~2019-03-22 0:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190320140846.13031-1-tromey@adacore.com>
2019-03-20 16:21 ` Pedro Alves
2019-03-21 22:05 ` Sergio Durigan Junior
2019-03-22 0:01 ` Sergio Durigan Junior [this message]
2019-03-25 15:35 ` Tom Tromey
2019-03-25 16:34 ` Pedro Alves
2019-03-25 16:46 ` Tom Tromey
2019-03-25 22:20 ` Sergio Durigan Junior
2019-03-26 13:13 ` Tom Tromey
2019-03-26 16:07 ` Sergio Durigan Junior
2019-03-26 18:45 ` Tom Tromey
2019-03-26 21:50 ` Sergio Durigan Junior
2019-03-27 12:57 ` Tom Tromey
2019-03-28 14:12 ` Pedro Alves
2019-03-29 21:44 ` [PATCH] Destroy allocated values when exiting GDB (was: Re: [PATCH] Merge handle_inferior_event and handle_inferior_event_1) Sergio Durigan Junior
2019-04-01 14:08 ` [PATCH] Destroy allocated values when exiting GDB Pedro Alves
2019-04-01 14:59 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mulnkcab.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox