From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tom@tromey.com>, Sergio Durigan Junior <sergiodj@redhat.com>
Cc: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Merge handle_inferior_event and handle_inferior_event_1
Date: Thu, 28 Mar 2019 14:12:00 -0000 [thread overview]
Message-ID: <5a2d4016-9e4d-dc18-8c3a-2c9ecf214c94@redhat.com> (raw)
In-Reply-To: <87sgv81nld.fsf@tromey.com>
On 03/27/2019 12:57 PM, Tom Tromey wrote:
> Sergio> I did that, and we (Pedro, Mark, Frank and I) did a session of
> Sergio> collective investigation. I summarized what we found here:
> Sergio> https://bugzilla.redhat.com/show_bug.cgi?id=1690120#c25
>
> Thanks, that's very interesting.
> I suppose either better control over the order of destruction is needed,
> or maybe finalize_python should clear gdb_python_initialized and then
> this should be checked in xmethod destructor.
I think the former is better. I think we should put an
all_values.clear ();
call in quit_force, before the do_final_cleanups call. Even
better, add a new finalize_values function next to
_initialize_values, and call that.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2019-03-28 14:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190320140846.13031-1-tromey@adacore.com>
2019-03-20 16:21 ` Pedro Alves
2019-03-21 22:05 ` Sergio Durigan Junior
2019-03-22 0:01 ` Sergio Durigan Junior
2019-03-25 15:35 ` Tom Tromey
2019-03-25 16:34 ` Pedro Alves
2019-03-25 16:46 ` Tom Tromey
2019-03-25 22:20 ` Sergio Durigan Junior
2019-03-26 13:13 ` Tom Tromey
2019-03-26 16:07 ` Sergio Durigan Junior
2019-03-26 18:45 ` Tom Tromey
2019-03-26 21:50 ` Sergio Durigan Junior
2019-03-27 12:57 ` Tom Tromey
2019-03-28 14:12 ` Pedro Alves [this message]
2019-03-29 21:44 ` [PATCH] Destroy allocated values when exiting GDB (was: Re: [PATCH] Merge handle_inferior_event and handle_inferior_event_1) Sergio Durigan Junior
2019-04-01 14:08 ` [PATCH] Destroy allocated values when exiting GDB Pedro Alves
2019-04-01 14:59 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a2d4016-9e4d-dc18-8c3a-2c9ecf214c94@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=sergiodj@redhat.com \
--cc=tom@tromey.com \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox