From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6592 invoked by alias); 28 Mar 2019 14:12:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6579 invoked by uid 89); 28 Mar 2019 14:12:47 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.1 spammy=H*f:sk:87mulnk, H*f:sk:87r2azk, H*f:sk:87a7hjj, H*f:sk:f4df53c X-HELO: mail-wm1-f45.google.com Received: from mail-wm1-f45.google.com (HELO mail-wm1-f45.google.com) (209.85.128.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 28 Mar 2019 14:12:46 +0000 Received: by mail-wm1-f45.google.com with SMTP id v14so4217296wmf.2 for ; Thu, 28 Mar 2019 07:12:45 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:4c97:6d52:2cea:997b? ([2001:8a0:f913:f700:4c97:6d52:2cea:997b]) by smtp.gmail.com with ESMTPSA id o6sm12190617wrp.41.2019.03.28.07.12.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Mar 2019 07:12:43 -0700 (PDT) Subject: Re: [PATCH] Merge handle_inferior_event and handle_inferior_event_1 To: Tom Tromey , Sergio Durigan Junior References: <20190320140846.13031-1-tromey@adacore.com> <87r2azkhmq.fsf@redhat.com> <87mulnkcab.fsf@redhat.com> <87a7hjj7aw.fsf@tromey.com> <87ef6uj408.fsf@tromey.com> <87mulia94w.fsf@redhat.com> <87sgv9bwyg.fsf@tromey.com> <87tvfpr55a.fsf@redhat.com> <87y351mhki.fsf@redhat.com> <87sgv81nld.fsf@tromey.com> Cc: Tom Tromey , gdb-patches@sourceware.org From: Pedro Alves Message-ID: <5a2d4016-9e4d-dc18-8c3a-2c9ecf214c94@redhat.com> Date: Thu, 28 Mar 2019 14:12:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <87sgv81nld.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-03/txt/msg00715.txt.bz2 On 03/27/2019 12:57 PM, Tom Tromey wrote: > Sergio> I did that, and we (Pedro, Mark, Frank and I) did a session of > Sergio> collective investigation. I summarized what we found here: > Sergio> https://bugzilla.redhat.com/show_bug.cgi?id=1690120#c25 > > Thanks, that's very interesting. > I suppose either better control over the order of destruction is needed, > or maybe finalize_python should clear gdb_python_initialized and then > this should be checked in xmethod destructor. I think the former is better. I think we should put an all_values.clear (); call in quit_force, before the do_final_cleanups call. Even better, add a new finalize_values function next to _initialize_values, and call that. Thanks, Pedro Alves