From: Tom Tromey <tromey@adacore.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: Tom Tromey <tom@tromey.com>, Pedro Alves <palves@redhat.com>,
Tom Tromey <tromey@adacore.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH] Merge handle_inferior_event and handle_inferior_event_1
Date: Tue, 26 Mar 2019 13:13:00 -0000 [thread overview]
Message-ID: <87sgv9bwyg.fsf@tromey.com> (raw)
In-Reply-To: <87mulia94w.fsf@redhat.com> (Sergio Durigan Junior's message of "Mon, 25 Mar 2019 18:20:47 -0400")
>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
>> Also, if a crash can occur during value destruction like this, then I
>> think it must indicate a bug somewhere else, like invalid reference
>> counting somewhere.
Sergio> That's a good point, yeah. I can try investigating more.
Maybe one idea would be to back out my patch and then run the failing
test under valgrind.
Sergio> Having said that, I think the patch is simple enough to be safely
Sergio> backportable to 8.3, and it doesn't really break anything (in fact, as
Sergio> Pedro mentioned, it makes things more correct, because now we're sure
Sergio> that we will destroy the objects if an exception is thrown), so IMHO
Sergio> there's no downside to it. WDYT?
I agree.
Tom
next prev parent reply other threads:[~2019-03-26 13:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190320140846.13031-1-tromey@adacore.com>
2019-03-20 16:21 ` Pedro Alves
2019-03-21 22:05 ` Sergio Durigan Junior
2019-03-22 0:01 ` Sergio Durigan Junior
2019-03-25 15:35 ` Tom Tromey
2019-03-25 16:34 ` Pedro Alves
2019-03-25 16:46 ` Tom Tromey
2019-03-25 22:20 ` Sergio Durigan Junior
2019-03-26 13:13 ` Tom Tromey [this message]
2019-03-26 16:07 ` Sergio Durigan Junior
2019-03-26 18:45 ` Tom Tromey
2019-03-26 21:50 ` Sergio Durigan Junior
2019-03-27 12:57 ` Tom Tromey
2019-03-28 14:12 ` Pedro Alves
2019-03-29 21:44 ` [PATCH] Destroy allocated values when exiting GDB (was: Re: [PATCH] Merge handle_inferior_event and handle_inferior_event_1) Sergio Durigan Junior
2019-04-01 14:08 ` [PATCH] Destroy allocated values when exiting GDB Pedro Alves
2019-04-01 14:59 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgv9bwyg.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=sergiodj@redhat.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox