From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3903 invoked by alias); 26 Mar 2019 13:13:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3889 invoked by uid 89); 26 Mar 2019 13:13:16 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.4 required=5.0 tests=AWL,BAYES_00,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.1 spammy=HX-Languages-Length:830, H*f:sk:87mulnk, H*f:sk:87r2azk, destruction X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 26 Mar 2019 13:13:14 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 3C4DB116C4D; Tue, 26 Mar 2019 09:13:13 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id O+La7+Oibsbv; Tue, 26 Mar 2019 09:13:13 -0400 (EDT) Received: from murgatroyd (174-29-37-56.hlrn.qwest.net [174.29.37.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPSA id 93C00116C39; Tue, 26 Mar 2019 09:13:12 -0400 (EDT) From: Tom Tromey To: Sergio Durigan Junior Cc: Tom Tromey , Pedro Alves , Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Merge handle_inferior_event and handle_inferior_event_1 References: <20190320140846.13031-1-tromey@adacore.com> <87r2azkhmq.fsf@redhat.com> <87mulnkcab.fsf@redhat.com> <87a7hjj7aw.fsf@tromey.com> <87ef6uj408.fsf@tromey.com> <87mulia94w.fsf@redhat.com> Date: Tue, 26 Mar 2019 13:13:00 -0000 In-Reply-To: <87mulia94w.fsf@redhat.com> (Sergio Durigan Junior's message of "Mon, 25 Mar 2019 18:20:47 -0400") Message-ID: <87sgv9bwyg.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-03/txt/msg00581.txt.bz2 >>>>> "Sergio" == Sergio Durigan Junior writes: >> Also, if a crash can occur during value destruction like this, then I >> think it must indicate a bug somewhere else, like invalid reference >> counting somewhere. Sergio> That's a good point, yeah. I can try investigating more. Maybe one idea would be to back out my patch and then run the failing test under valgrind. Sergio> Having said that, I think the patch is simple enough to be safely Sergio> backportable to 8.3, and it doesn't really break anything (in fact, as Sergio> Pedro mentioned, it makes things more correct, because now we're sure Sergio> that we will destroy the objects if an exception is thrown), so IMHO Sergio> there's no downside to it. WDYT? I agree. Tom