From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 119307 invoked by alias); 26 Mar 2019 16:07:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 119296 invoked by uid 89); 26 Mar 2019 16:07:17 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,KAM_NUMSUBJECT,SPF_HELO_PASS autolearn=no version=3.3.1 spammy=H*f:sk:87mulnk, H*f:sk:87r2azk, sergiodj@redhat.com, H*f:sk:87a7hjj X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 26 Mar 2019 16:07:16 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0DD81308620D; Tue, 26 Mar 2019 16:07:15 +0000 (UTC) Received: from localhost (unused-10-15-17-196.yyz.redhat.com [10.15.17.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3BC2F60BE6; Tue, 26 Mar 2019 16:07:14 +0000 (UTC) From: Sergio Durigan Junior To: Tom Tromey Cc: Tom Tromey , Pedro Alves , gdb-patches@sourceware.org Subject: Re: [PATCH] Merge handle_inferior_event and handle_inferior_event_1 References: <20190320140846.13031-1-tromey@adacore.com> <87r2azkhmq.fsf@redhat.com> <87mulnkcab.fsf@redhat.com> <87a7hjj7aw.fsf@tromey.com> <87ef6uj408.fsf@tromey.com> <87mulia94w.fsf@redhat.com> <87sgv9bwyg.fsf@tromey.com> Date: Tue, 26 Mar 2019 16:07:00 -0000 In-Reply-To: <87sgv9bwyg.fsf@tromey.com> (Tom Tromey's message of "Tue, 26 Mar 2019 07:13:11 -0600") Message-ID: <87tvfpr55a.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00597.txt.bz2 On Tuesday, March 26 2019, Tom Tromey wrote: >>>>>> "Sergio" == Sergio Durigan Junior writes: > >>> Also, if a crash can occur during value destruction like this, then I >>> think it must indicate a bug somewhere else, like invalid reference >>> counting somewhere. > > Sergio> That's a good point, yeah. I can try investigating more. > > Maybe one idea would be to back out my patch and then run the failing > test under valgrind. Thanks. > Sergio> Having said that, I think the patch is simple enough to be safely > Sergio> backportable to 8.3, and it doesn't really break anything (in fact, as > Sergio> Pedro mentioned, it makes things more correct, because now we're sure > Sergio> that we will destroy the objects if an exception is thrown), so IMHO > Sergio> there's no downside to it. WDYT? > > I agree. Thanks, Tom. I created . Would you like me to go ahead and backport the patch to the 8.3 branch, or do you want to do that? Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/