From: Tom Tromey <tom@tromey.com>
To: Aditya Vidyadhar Kamath <akamath996@gmail.com>
Cc: ulrich.weigand@de.ibm.com, tom@tromey.com,
gdb-patches@sourceware.org, Aditya.Kamath1@ibm.com,
sangamesh.swamy@in.ibm.com
Subject: Re: [PATCH] Fix AIX CI build break.
Date: Mon, 13 Jan 2025 02:08:48 -0700 [thread overview]
Message-ID: <87tta3ullr.fsf@tromey.com> (raw)
In-Reply-To: <20250113044351.45450-1-akamath996@gmail.com> (Aditya Vidyadhar Kamath's message of "Mon, 13 Jan 2025 10:13:52 +0530")
>>>>> Aditya Vidyadhar Kamath <akamath996@gmail.com> writes:
> A feature development made by the recent commit
> https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=6447969d0ac774b6dec0f95a0d3d27c27d158690
> missed to guard Python.h in HAVE_PYTHON macro.
> This commit is a fix for the same.
Sorry about that.
> +
> +#ifdef HAVE_PYTHON
> #include "py-color.h"
> +#endif /* HAVE_PYTHON */
Rather than a new #ifdef, could you just move the #include into the
already-existing #ifdef block? Thanks.
Tom
next prev parent reply other threads:[~2025-01-13 9:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-13 4:43 Aditya Vidyadhar Kamath
2025-01-13 9:08 ` Tom Tromey [this message]
2025-01-13 10:35 ` Aditya Kamath
2025-10-10 10:36 Aditya Vidyadhar Kamath
2025-10-10 10:52 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tta3ullr.fsf@tromey.com \
--to=tom@tromey.com \
--cc=Aditya.Kamath1@ibm.com \
--cc=akamath996@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=sangamesh.swamy@in.ibm.com \
--cc=ulrich.weigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox