RE: [PATCH] Fix AIX CI build break.

[Aditya Kamath <Aditya.Kamath1@ibm.com>]

[-- Attachment #1: Type: text/plain, Size: 1247 bytes --]

Hi Tom,

>Rather than a new #ifdef, could you just move the #include into the
>already-existing #ifdef block?  Thanks.

Thank you for noticing. I had missed it. I have made the change and sent a v2 of the patch requesting approval to commit.
Have a nice day ahead.

Regards,
Aditya.

From: Tom Tromey <tom@tromey.com>
Date: Monday, 13 January 2025 at 2:38 PM
To: Aditya Vidyadhar Kamath <akamath996@gmail.com>
Cc: Ulrich Weigand <Ulrich.Weigand@de.ibm.com>, tom@tromey.com <tom@tromey.com>, gdb-patches@sourceware.org <gdb-patches@sourceware.org>, Aditya Kamath <Aditya.Kamath1@ibm.com>, SANGAMESH MALLAYYA <sangamesh.swamy@in.ibm.com>
Subject: [EXTERNAL] Re: [PATCH] Fix AIX CI build break.
>>>>> Aditya Vidyadhar Kamath <akamath996@gmail.com> writes:

> A feature development made by the recent commit
> https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=6447969d0ac774b6dec0f95a0d3d27c27d158690 
> missed to guard Python.h in HAVE_PYTHON macro.

> This commit is a fix for the same.

Sorry about that.

> +
> +#ifdef HAVE_PYTHON
>  #include "py-color.h"
> +#endif /* HAVE_PYTHON */

Rather than a new #ifdef, could you just move the #include into the
already-existing #ifdef block?  Thanks.

Tom

[-- Attachment #2: Type: text/html, Size: 4195 bytes --]