Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Ulrich Weigand <Ulrich.Weigand@de.ibm.com>
To: "akamath996@gmail.com" <akamath996@gmail.com>,
	"tom@tromey.com" <tom@tromey.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
	SANGAMESH MALLAYYA <sangamesh.swamy@in.ibm.com>,
	Aditya Kamath <Aditya.Kamath1@ibm.com>
Subject: Re: [PATCH] Fix AIX CI build break.
Date: Fri, 10 Oct 2025 10:52:13 +0000	[thread overview]
Message-ID: <215222d1bbe6f40057bbaabb01619e3541e5f110.camel@de.ibm.com> (raw)
In-Reply-To: <20251010103638.51128-2-akamath996@gmail.com>

>diff --git a/gdb/aix-thread.c b/gdb/aix-thread.c
>index 1e3015d77b0..7007f76b85a 100644
>--- a/gdb/aix-thread.c
>+++ b/gdb/aix-thread.c
>@@ -854,14 +854,14 @@ sync_threadlists (pid_t pid)
>        thread exits and gets into a PST_UNKNOWN state.  So this
thread
>        will not run in the above for loop.  Therefore the below for
loop
>        is to manually delete such threads.  */
>-    for (struct thread_info *it : all_threads_safe ())
>+    for (thread_info &it : all_threads_safe ())
>       {
>-	aix_thread_info *priv = get_aix_thread_info (it);
>+	aix_thread_info *priv = get_aix_thread_info (&it);
> 	if (in_queue_threads.count (priv->pdtid) == 0
>-		&& in_thread_list (proc_target, it->ptid)
>-		&& pid == it->ptid.pid ())
>+		&& in_thread_list (proc_target, it.ptid)
>+		&& pid == it.ptid.pid ())
> 	  {
>-	    delete_thread (it);
>+	    delete_thread (&it);
> 	    data->exited_threads.insert (priv->pdtid);
> 	  }
>       }

This is OK.

Thanks,
Ulrich


  reply	other threads:[~2025-10-10 10:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-10 10:36 Aditya Vidyadhar Kamath
2025-10-10 10:52 ` Ulrich Weigand [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-01-13  4:43 Aditya Vidyadhar Kamath
2025-01-13  9:08 ` Tom Tromey
2025-01-13 10:35   ` Aditya Kamath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=215222d1bbe6f40057bbaabb01619e3541e5f110.camel@de.ibm.com \
    --to=ulrich.weigand@de.ibm.com \
    --cc=Aditya.Kamath1@ibm.com \
    --cc=akamath996@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=sangamesh.swamy@in.ibm.com \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox