Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Aditya Vidyadhar Kamath <akamath996@gmail.com>
To: ulrich.weigand@de.ibm.com, tom@tromey.com
Cc: gdb-patches@sourceware.org, Aditya.Kamath1@ibm.com,
	sangamesh.swamy@in.ibm.com
Subject: [PATCH] Fix AIX CI build break.
Date: Mon, 13 Jan 2025 10:13:52 +0530	[thread overview]
Message-ID: <20250113044351.45450-1-akamath996@gmail.com> (raw)

From: KamathForAIX <Aditya.Kamath1@ibm.com>

In AIX a recent commit caused a build break with the error as shown below.
In file included from python/py-color.h:23,
                 from python/python.c:39:
python/python-internal.h:86:10: fatal error: Python.h: No such file or directory
   86 | #include <Python.h>

In AIX, we run builds with and without python for our internal CI's.

A feature development made by the recent commit https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=6447969d0ac774b6dec0f95a0d3d27c27d158690
missed to guard Python.h in HAVE_PYTHON macro.

This commit is a fix for the same.
---
 gdb/python/python.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gdb/python/python.c b/gdb/python/python.c
index 15bb9129739..f647e6aaf4c 100644
--- a/gdb/python/python.c
+++ b/gdb/python/python.c
@@ -36,7 +36,10 @@
 #include "run-on-main-thread.h"
 #include "observable.h"
 #include "build-id.h"
+
+#ifdef HAVE_PYTHON
 #include "py-color.h"
+#endif /* HAVE_PYTHON */
 
 #if GDB_SELF_TEST
 #include "gdbsupport/selftest.h"
-- 
2.41.0


             reply	other threads:[~2025-01-13  4:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-13  4:43 Aditya Vidyadhar Kamath [this message]
2025-01-13  9:08 ` Tom Tromey
2025-01-13 10:35   ` Aditya Kamath
2025-10-10 10:36 Aditya Vidyadhar Kamath
2025-10-10 10:52 ` Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250113044351.45450-1-akamath996@gmail.com \
    --to=akamath996@gmail.com \
    --cc=Aditya.Kamath1@ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=sangamesh.swamy@in.ibm.com \
    --cc=tom@tromey.com \
    --cc=ulrich.weigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox