From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id sg2iFGDYhGeGsQwAWB0awg (envelope-from ) for ; Mon, 13 Jan 2025 04:09:52 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=kgWpwg2t; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 4437A1E0C0; Mon, 13 Jan 2025 04:09:52 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4961E1E091 for ; Mon, 13 Jan 2025 04:09:51 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C89843858027 for ; Mon, 13 Jan 2025 09:09:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C89843858027 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=kgWpwg2t Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id 406E1385780F for ; Mon, 13 Jan 2025 09:08:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 406E1385780F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 406E1385780F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736759332; cv=none; b=ustPx24FbdzncMK6Rs9CV+zskDqHhQsELDAh7vz4zF9qiUetKbyu/HNf7Hht4WWlKl85Oq42MxGI0rFU6efjHeqcCYBvORgQq+vCUzdSn13zsa0aCTouPyRWe8VQ2hNJJX7tie5j1ymmxxe9ZH6xqQ7jb0MHyKEW3diW8rLB+eI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736759332; c=relaxed/simple; bh=D0ddJiKV4rzq8IfWCFLK1IwtMkYNhvaO6iuhbM6ozxw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=us8kUtThrWSZir501+lUolZCW6rqDoPF/cPEwHD3bR9bBSoSNfcPyYDZOCPYSfrpZh3G87Tt+giThIwCkRDE7RkQt80GuRZNSR3YuYB7Ja9dfKBX4ep6Bs6ZEKB9WadfzpM3VkgYAIrv/drHez3TbEu+JQ/LcMUm5phcFwMQpy4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 406E1385780F Received: from eig-obgw-5007a.ext.cloudfilter.net ([10.0.29.141]) by cmsmtp with ESMTPS id WblCtixO0qewVXGRHtbJ9Q; Mon, 13 Jan 2025 09:08:51 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id XGRGtgSnHXymlXGRGtixW4; Mon, 13 Jan 2025 09:08:50 +0000 X-Authority-Analysis: v=2.4 cv=Z+/qHmRA c=1 sm=1 tr=0 ts=6784d822 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=VdSt8ZQiCzkA:10 a=ItBw4LHWJt0A:10 a=CCpqsmhAAAAA:8 a=pGLkceISAAAA:8 a=AWPabLpD6vtrlNkvhtYA:9 a=ul9cdbp4aOFLsgKbc677:22 a=6Ogn3jAGHLSNbaov7Orx:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=rW7V5efX2gkPDhwncsU2DRejtVLBET51cTbh3lH+hJQ=; b=kgWpwg2tPIUDbqfI4n8ot7m9SA WKjAee/5XCaL7r6nU0EugEphbujsmbLagqqjsG94ER3zhH0zCpd6OwJnw5mLiQHzBcCtiFAB6qJ1T mIZbpTX7fR/lzoIdsiPJnBI1r; Received: from 97-118-36-154.hlrn.qwest.net ([97.118.36.154]:45800 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1tXGRF-000719-2n; Mon, 13 Jan 2025 02:08:49 -0700 From: Tom Tromey To: Aditya Vidyadhar Kamath Cc: ulrich.weigand@de.ibm.com, tom@tromey.com, gdb-patches@sourceware.org, Aditya.Kamath1@ibm.com, sangamesh.swamy@in.ibm.com Subject: Re: [PATCH] Fix AIX CI build break. In-Reply-To: <20250113044351.45450-1-akamath996@gmail.com> (Aditya Vidyadhar Kamath's message of "Mon, 13 Jan 2025 10:13:52 +0530") References: <20250113044351.45450-1-akamath996@gmail.com> X-Attribution: Tom Date: Mon, 13 Jan 2025 02:08:48 -0700 Message-ID: <87tta3ullr.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.118.36.154 X-Source-L: No X-Exim-ID: 1tXGRF-000719-2n X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-118-36-154.hlrn.qwest.net (prentzel) [97.118.36.154]:45800 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfOOHckJYpx1RZ1CQeYFr1g7lQQtka0o64473JVZMEgvRar9TQ6xIzXe50gxF/Vmn8A8tVy0d3Kc6tI1CLeScX8pe9w/5JLMdTaOHQ8EhTPil2Ka03kY8 AgLzuWvXbbzKd6vqAnX9vg7HNdW4/yoVKAK8xGzJBKd51xzPoe3NhYR67pWY3oTd3f5rPfo2SV6PR/5vh8BSsObIgoo4QtFxzhA= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> Aditya Vidyadhar Kamath writes: > A feature development made by the recent commit > https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=6447969d0ac774b6dec0f95a0d3d27c27d158690 > missed to guard Python.h in HAVE_PYTHON macro. > This commit is a fix for the same. Sorry about that. > + > +#ifdef HAVE_PYTHON > #include "py-color.h" > +#endif /* HAVE_PYTHON */ Rather than a new #ifdef, could you just move the #include into the already-existing #ifdef block? Thanks. Tom