Re: [PATCH V2 5/9] New probe type: DTrace USDT probes.

[jose.marchesi@oracle.com (Jose E. Marchesi)]

    > +enum dtrace_dof_sect_type
    > +{
    > +  DTRACE_DOF_SECT_TYPE_NONE     = 0,  /* Null section.  */
    > +  DTRACE_DOF_SECT_TYPE_ECBDESC  = 3,  /* A dof_ecbdesc_t. */
    > +  DTRACE_DOF_SECT_TYPE_STRTAB   = 8,  /* A string table.  */
    > +  DTRACE_DOF_SECT_TYPE_PROVIDER = 15, /* A dof_provider_t  */
    > +  DTRACE_DOF_SECT_TYPE_PROBES   = 16, /* Array of dof_probe_t  */
    > +  DTRACE_DOF_SECT_TYPE_PRARGS   = 17, /* An array of probe arg
    > +					 mappings.  */
    > +  DTRACE_DOF_SECT_TYPE_PROFFS   = 18, /* An array of probe arg
    > +					 offsets.  */
    > +  DTRACE_DOF_SECT_TYPE_PRENOFFS = 26  /* An array of probe is-enabled
    > +					 offsets.  */
    > +};
    
    I think there is a convention we follow that says that comments should
    go on top of each item.  It would be nice if you did that :-).

I don't really have a strong preference of either style, so I changed
the comments in the enums and structs to go on top of the documented
item.
    
    Otherwise, looks good to me (still waiting for the testcase, though
    :-P).

I am working on that... patience :)