Re: [PATCH V2 3/9] New commands `enable probe' and `disable probe'.

[Sergio Durigan Junior <sergiodj@redhat.com>]

On Thursday, October 16 2014, Pedro Alves wrote:

> On 10/11/2014 07:39 AM, Jose E. Marchesi wrote:
>> 
>> (gdb) info probes
>> Provider Name             Where              Semaphore Enabled Object                         
>> demo     am-main          0x0000000000400c96           n/a     /home/jemarch/oracle/usdt/demo 
>> demo     another          0x0000000000400c8b n/a       always  /home/jemarch/oracle/usdt/demo 
>> demo     progress-counter 0x0000000000400c81 n/a       no      /home/jemarch/oracle/usdt/demo
>> 
>> In the example above demo:am-main is a systemtap probe, for which
>> "Enabled" reads n/a.  demo:another is a dtrace probe which cannot be
>> disabled (it does not have any associated enabler) and
>> demo:progress-counter is a dtrace probe which is disabled.
>
> Shouldn't we explicitly say which probe is stap, vs dprobe (vs whatever
> other probe type)?  Like, either a new column:

This is actually a nice idea, and if I say that I thought about it while
testing the patch, but then forgot to mention, would it seem strange?  :-)

> ~~~
> Type    Provider Name             Where              Semaphore Enabled Object
> stap    demo     am-main          0x0000000000400c96           n/a     /home/jemarch/oracle/usdt/demo
> dtrace  demo     another          0x0000000000400c8b n/a       always  /home/jemarch/oracle/usdt/demo
> dtrace  demo     progress-counter 0x0000000000400c81 n/a       no      /home/jemarch/oracle/usdt/demo
> ~~~
>
> or, sort output by probe type:

I prefer a new column.

> ~~~
> Stap probes:
>
> Type    Provider Name             Where              Semaphore Enabled Object
> stap    demo     am-main          0x0000000000400c96           n/a     /home/jemarch/oracle/usdt/demo
>
> Dtrace probes:
>
> Type    Provider Name             Where              Semaphore Enabled Object
> dtrace  demo     another          0x0000000000400c8b n/a       always  /home/jemarch/oracle/usdt/demo
> dtrace  demo     progress-counter 0x0000000000400c81 n/a       no      /home/jemarch/oracle/usdt/demo
> ~~~

Thanks.

-- 
Sergio
GPG key ID: 0x65FC5E36
Please send encrypted e-mail if possible
http://sergiodj.net/