From: Eli Zaretskii <eliz@gnu.org>
To: "Jose E. Marchesi" <jose.marchesi@oracle.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH V2 3/9] New commands `enable probe' and `disable probe'.
Date: Fri, 10 Oct 2014 18:15:00 -0000 [thread overview]
Message-ID: <83fvevaj0b.fsf@gnu.org> (raw)
In-Reply-To: <1412961772-16249-4-git-send-email-jose.marchesi@oracle.com>
> From: "Jose E. Marchesi" <jose.marchesi@oracle.com>
> Date: Fri, 10 Oct 2014 19:22:46 +0200
>
> +Some probe points can be enabled and/or disabled. The effects
> +associated to enabling or disabling a probe depend on the type of
Just "the effect of enabling or disabling a probe" is enough, and much
more clear.
> +probe being handled. @code{SystemTap} probes do not support these
^^
Two spaces between sentences.
Also, I think we agreed to say SystemTap probes cannot be disabled.
> +@item enable probes @r{[}@var{provider} @r{[}@var{name} @r{[}@var{objfile}@r{]}@r{]}@r{]}
> +If given, @var{provider} is a regular expression used to match against
> +provider names when selecting which probes to enable. If omitted,
> +probes by all probes from all providers are enabled.
"Probes by all probes"? Something is wrong here.
Thanks.
next prev parent reply other threads:[~2014-10-10 18:15 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-10 17:18 [PATCH V2 0/9] Add support for DTrace USDT probes to gdb Jose E. Marchesi
2014-10-10 17:18 ` [PATCH V2 9/9] Announce the DTrace USDT probes support in NEWS Jose E. Marchesi
2014-10-10 18:16 ` Eli Zaretskii
2014-10-10 17:18 ` [PATCH V2 7/9] Simple testsuite for DTrace USDT probes Jose E. Marchesi
2014-10-16 22:36 ` Pedro Alves
2014-10-17 12:01 ` Jose E. Marchesi
2014-10-17 12:18 ` Pedro Alves
2014-10-10 17:18 ` [PATCH V2 3/9] New commands `enable probe' and `disable probe' Jose E. Marchesi
2014-10-10 18:15 ` Eli Zaretskii [this message]
2014-10-10 22:03 ` Doug Evans
2014-10-11 6:35 ` Jose E. Marchesi
2014-10-13 16:41 ` Doug Evans
2014-10-14 19:02 ` Sergio Durigan Junior
2014-10-17 0:07 ` Doug Evans
2014-10-17 0:36 ` Pedro Alves
2014-10-17 0:43 ` Pedro Alves
2014-10-17 2:31 ` Sergio Durigan Junior
2014-10-17 11:23 ` Pedro Alves
2014-10-17 0:55 ` Sergio Durigan Junior
2014-10-17 5:52 ` Jose E. Marchesi
2014-10-11 17:04 ` Sergio Durigan Junior
2014-10-14 18:53 ` Sergio Durigan Junior
2014-10-15 13:28 ` Jose E. Marchesi
2014-10-10 17:18 ` [PATCH V2 8/9] Documentation for DTrace USDT probes Jose E. Marchesi
2014-10-10 18:18 ` Eli Zaretskii
2014-10-10 17:18 ` [PATCH V2 2/9] Move `compute_probe_arg' and `compile_probe_arg' to probe.c Jose E. Marchesi
2014-10-10 17:18 ` [PATCH V2 4/9] New gdbarch functions: dtrace_parse_probe_argument, dtrace_probe_is_enabled, dtrace_enable_probe, dtrace_disable_probe Jose E. Marchesi
2014-10-10 17:18 ` [PATCH V2 6/9] Support for DTrace USDT probes in x86_64 targets Jose E. Marchesi
2014-10-16 22:07 ` Pedro Alves
2014-10-17 12:35 ` Jose E. Marchesi
2014-10-17 12:42 ` Pedro Alves
2014-10-17 12:47 ` Jose E. Marchesi
2014-10-17 12:53 ` Pedro Alves
2014-10-17 19:48 ` Jose E. Marchesi
2014-10-16 22:07 ` Pedro Alves
2014-10-16 22:17 ` Pedro Alves
2014-10-10 17:18 ` [PATCH V2 5/9] New probe type: DTrace USDT probes Jose E. Marchesi
2014-10-14 19:01 ` Sergio Durigan Junior
2014-10-15 13:28 ` Jose E. Marchesi
2014-10-10 17:18 ` [PATCH V2 1/9] Adapt `info probes' to support printing probes of different types Jose E. Marchesi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83fvevaj0b.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=jose.marchesi@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox