From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-116597-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 10727 invoked by alias); 10 Oct 2014 18:15:47 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 10714 invoked by uid 89); 10 Oct 2014 18:15:46 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: mtaout25.012.net.il
Received: from mtaout25.012.net.il (HELO mtaout25.012.net.il) (80.179.55.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 10 Oct 2014 18:15:45 +0000
Received: from conversion-daemon.mtaout25.012.net.il by mtaout25.012.net.il (HyperSendmail v2007.08) id <0ND800F00P7CLT00@mtaout25.012.net.il> for gdb-patches@sourceware.org; Fri, 10 Oct 2014 21:10:56 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout25.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0ND800FTMQI8VW30@mtaout25.012.net.il>; Fri, 10 Oct 2014 21:10:56 +0300 (IDT)
Date: Fri, 10 Oct 2014 18:15:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH V2 3/9] New commands `enable probe' and `disable probe'.
In-reply-to: <1412961772-16249-4-git-send-email-jose.marchesi@oracle.com>
To: "Jose E. Marchesi" <jose.marchesi@oracle.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83fvevaj0b.fsf@gnu.org>
References: <1412961772-16249-1-git-send-email-jose.marchesi@oracle.com> <1412961772-16249-4-git-send-email-jose.marchesi@oracle.com>
X-IsSubscribed: yes
X-SW-Source: 2014-10/txt/msg00273.txt.bz2

> From: "Jose E. Marchesi" <jose.marchesi@oracle.com>
> Date: Fri, 10 Oct 2014 19:22:46 +0200
> 
> +Some probe points can be enabled and/or disabled.  The effects
> +associated to enabling or disabling a probe depend on the type of

Just "the effect of enabling or disabling a probe" is enough, and much
more clear.

> +probe being handled. @code{SystemTap} probes do not support these
                      ^^
Two spaces between sentences.

Also, I think we agreed to say SystemTap probes cannot be disabled.

> +@item enable probes @r{[}@var{provider} @r{[}@var{name} @r{[}@var{objfile}@r{]}@r{]}@r{]}
> +If given, @var{provider} is a regular expression used to match against
> +provider names when selecting which probes to enable.  If omitted,
> +probes by all probes from all providers are enabled.

"Probes by all probes"?  Something is wrong here.

Thanks.