From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3778 invoked by alias); 17 Oct 2014 00:55:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3769 invoked by uid 89); 17 Oct 2014 00:55:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,LIKELY_SPAM_BODY,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 17 Oct 2014 00:55:38 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9H0tWuc025468 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 16 Oct 2014 20:55:32 -0400 Received: from localhost (dhcp-10-15-16-169.yyz.redhat.com [10.15.16.169]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s9H0tVog003648 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Thu, 16 Oct 2014 20:55:31 -0400 From: Sergio Durigan Junior To: Pedro Alves Cc: "Jose E. Marchesi" , Doug Evans , gdb-patches@sourceware.org Subject: Re: [PATCH V2 3/9] New commands `enable probe' and `disable probe'. References: <1412961772-16249-1-git-send-email-jose.marchesi@oracle.com> <1412961772-16249-4-git-send-email-jose.marchesi@oracle.com> <21560.22449.803178.90104@ruffy2.mtv.corp.google.com> <878uknun2f.fsf@oracle.com> <5440649C.6080705@redhat.com> X-URL: http://blog.sergiodj.net Date: Fri, 17 Oct 2014 00:55:00 -0000 In-Reply-To: <5440649C.6080705@redhat.com> (Pedro Alves's message of "Fri, 17 Oct 2014 01:36:44 +0100") Message-ID: <87mw8vfrb0.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg00451.txt.bz2 On Thursday, October 16 2014, Pedro Alves wrote: > On 10/11/2014 07:39 AM, Jose E. Marchesi wrote: >> >> (gdb) info probes >> Provider Name Where Semaphore Enabled Object >> demo am-main 0x0000000000400c96 n/a /home/jemarch/oracle/usdt/demo >> demo another 0x0000000000400c8b n/a always /home/jemarch/oracle/usdt/demo >> demo progress-counter 0x0000000000400c81 n/a no /home/jemarch/oracle/usdt/demo >> >> In the example above demo:am-main is a systemtap probe, for which >> "Enabled" reads n/a. demo:another is a dtrace probe which cannot be >> disabled (it does not have any associated enabler) and >> demo:progress-counter is a dtrace probe which is disabled. > > Shouldn't we explicitly say which probe is stap, vs dprobe (vs whatever > other probe type)? Like, either a new column: This is actually a nice idea, and if I say that I thought about it while testing the patch, but then forgot to mention, would it seem strange? :-) > ~~~ > Type Provider Name Where Semaphore Enabled Object > stap demo am-main 0x0000000000400c96 n/a /home/jemarch/oracle/usdt/demo > dtrace demo another 0x0000000000400c8b n/a always /home/jemarch/oracle/usdt/demo > dtrace demo progress-counter 0x0000000000400c81 n/a no /home/jemarch/oracle/usdt/demo > ~~~ > > or, sort output by probe type: I prefer a new column. > ~~~ > Stap probes: > > Type Provider Name Where Semaphore Enabled Object > stap demo am-main 0x0000000000400c96 n/a /home/jemarch/oracle/usdt/demo > > Dtrace probes: > > Type Provider Name Where Semaphore Enabled Object > dtrace demo another 0x0000000000400c8b n/a always /home/jemarch/oracle/usdt/demo > dtrace demo progress-counter 0x0000000000400c81 n/a no /home/jemarch/oracle/usdt/demo > ~~~ Thanks. -- Sergio GPG key ID: 0x65FC5E36 Please send encrypted e-mail if possible http://sergiodj.net/