From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 595 invoked by alias); 15 Oct 2014 13:28:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 566 invoked by uid 89); 15 Oct 2014 13:28:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.6 required=5.0 tests=AWL,BAYES_00,LIKELY_SPAM_BODY,SPF_PASS,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=no version=3.3.2 X-HELO: aserp1040.oracle.com Received: from aserp1040.oracle.com (HELO aserp1040.oracle.com) (141.146.126.69) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 15 Oct 2014 13:28:09 +0000 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s9FDS3Rh021386 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 15 Oct 2014 13:28:04 GMT Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s9FDS3YG016545 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 15 Oct 2014 13:28:03 GMT Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s9FDS36i016536; Wed, 15 Oct 2014 13:28:03 GMT Received: from termi.oracle.com (/62.156.150.204) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 15 Oct 2014 06:28:02 -0700 From: jose.marchesi@oracle.com (Jose E. Marchesi) To: Sergio Durigan Junior Cc: gdb-patches@sourceware.org Subject: Re: [PATCH V2 5/9] New probe type: DTrace USDT probes. References: <1412961772-16249-1-git-send-email-jose.marchesi@oracle.com> <1412961772-16249-6-git-send-email-jose.marchesi@oracle.com> <87a94yqxvj.fsf@redhat.com> Date: Wed, 15 Oct 2014 13:28:00 -0000 In-Reply-To: <87a94yqxvj.fsf@redhat.com> (Sergio Durigan Junior's message of "Tue, 14 Oct 2014 15:01:20 -0400") Message-ID: <87siiph305.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg00388.txt.bz2 > +enum dtrace_dof_sect_type > +{ > + DTRACE_DOF_SECT_TYPE_NONE = 0, /* Null section. */ > + DTRACE_DOF_SECT_TYPE_ECBDESC = 3, /* A dof_ecbdesc_t. */ > + DTRACE_DOF_SECT_TYPE_STRTAB = 8, /* A string table. */ > + DTRACE_DOF_SECT_TYPE_PROVIDER = 15, /* A dof_provider_t */ > + DTRACE_DOF_SECT_TYPE_PROBES = 16, /* Array of dof_probe_t */ > + DTRACE_DOF_SECT_TYPE_PRARGS = 17, /* An array of probe arg > + mappings. */ > + DTRACE_DOF_SECT_TYPE_PROFFS = 18, /* An array of probe arg > + offsets. */ > + DTRACE_DOF_SECT_TYPE_PRENOFFS = 26 /* An array of probe is-enabled > + offsets. */ > +}; I think there is a convention we follow that says that comments should go on top of each item. It would be nice if you did that :-). I don't really have a strong preference of either style, so I changed the comments in the enums and structs to go on top of the documented item. Otherwise, looks good to me (still waiting for the testcase, though :-P). I am working on that... patience :)