From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch 4/9] TUI: Use internally fullname
Date: Mon, 21 Jan 2013 18:57:00 -0000 [thread overview]
Message-ID: <87r4le1i04.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20130117215935.GE16249@host2.jankratochvil.net> (Jan Kratochvil's message of "Thu, 17 Jan 2013 22:59:35 +0100")
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> TUI was using comp_dir-relative "filaname" during matching.
Looks good to me.
Jan> - && (filename_cmp (src->filename, loc->symtab->filename) == 0)
Jan> + && filename_cmp (src->fullname,
Jan> + symtab_to_fullname (loc->symtab)) == 0
After your patches is it ever ok to refer directly to symtab->filename?
Tom
next prev parent reply other threads:[~2013-01-21 18:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-17 21:59 Jan Kratochvil
2013-01-21 18:57 ` Tom Tromey [this message]
2013-01-21 21:11 ` Jan Kratochvil
2013-01-22 6:55 ` Eli Zaretskii
2013-01-22 7:12 ` Jan Kratochvil
2013-01-22 8:24 ` Eli Zaretskii
2013-01-22 8:47 ` Jan Kratochvil
2013-01-22 11:44 ` Eli Zaretskii
2013-01-22 12:05 ` Jan Kratochvil
2013-01-22 13:23 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r4le1i04.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox