Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: tromey@redhat.com, gdb-patches@sourceware.org
Subject: Re: [patch 4/9] TUI: Use internally fullname
Date: Tue, 22 Jan 2013 08:24:00 -0000	[thread overview]
Message-ID: <83a9s1oc9w.fsf@gnu.org> (raw)
In-Reply-To: <20130122071205.GA31510@host2.jankratochvil.net>

> Date: Tue, 22 Jan 2013 08:12:05 +0100
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> Cc: tromey@redhat.com, gdb-patches@sourceware.org
> 
> > Why strip it?  We could resolve "." to an absolute file name using the
> > compilation directory, and then they will match, right?
> 
> That can be done for S->FILENAME and that is already done by
> symtab_to_fullname.
> 
> But for NAME - the string which user entered in "break ./gdb.base/return.c:main"
> - has no compilation nor "current" directory.

What is the semantics of such a 'break' command?  Does "." here mean
the current directory?  Or does it mean something else?

If the former, then we have the current directory in GDB, don't we?

> 	http://msdn.microsoft.com/en-us/library/windows/desktop/aa363788%28v=vs.85%29.aspx
> 	dwVolumeSerialNumber
> 	nFileIndexHigh
> 	nFileIndexLow
> 	The identifier (low and high parts) and the volume serial number
> 	uniquely identify a file on a single computer. To determine whether
> 	two open handles represent the same file, combine the identifier and
> 	the volume serial number for each file and compare them.
> 
> So I do not understand why MS-Windows stat call does not provide st_ino from
> those fields.

Because MS didn't bother to code that.

> I expect it is just a MS-Windows stat implementation bug probably
> workarounded in Cygwin but apparently not in MinGW?

Cygwin doesn't use the Windows runtime, it uses its own library.

MinGW does use the Windows runtime, and doesn't have a replacement for
'stat' in its "mingwex" library.  One complication with such a
replacement is that the FileIndex thing is a 64-bit quantity, while
'struct stat' in MS implementation uses a 'short' data type for it.
This creates binary incompatibility.  That's why I suggested a
separate method for retrieving the inode.


  reply	other threads:[~2013-01-22  8:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-17 21:59 Jan Kratochvil
2013-01-21 18:57 ` Tom Tromey
2013-01-21 21:11   ` Jan Kratochvil
2013-01-22  6:55     ` Eli Zaretskii
2013-01-22  7:12       ` Jan Kratochvil
2013-01-22  8:24         ` Eli Zaretskii [this message]
2013-01-22  8:47           ` Jan Kratochvil
2013-01-22 11:44             ` Eli Zaretskii
2013-01-22 12:05               ` Jan Kratochvil
2013-01-22 13:23                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83a9s1oc9w.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox