From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: tromey@redhat.com, gdb-patches@sourceware.org
Subject: Re: [patch 4/9] TUI: Use internally fullname
Date: Tue, 22 Jan 2013 08:47:00 -0000 [thread overview]
Message-ID: <20130122084648.GA2790@host2.jankratochvil.net> (raw)
In-Reply-To: <83a9s1oc9w.fsf@gnu.org>
On Tue, 22 Jan 2013 09:24:59 +0100, Eli Zaretskii wrote:
> > But for NAME - the string which user entered in "break ./gdb.base/return.c:main"
> > - has no compilation nor "current" directory.
>
> What is the semantics of such a 'break' command? Does "." here mean
> the current directory? Or does it mean something else?
It is compilation directory (DW_AT_comp_dir) relative name (therefore CU's
DW_AT_name).
Moreover recent GDBs allow to use also any trailing part, therefore not just
"break ./gdb.base/return.c:main" and "break return.c:main"
but also "break gdb.base/return.c".
> If the former, then we have the current directory in GDB, don't we?
Current directory of GDB can be somewhere completely else, it is not related.
I just try not to regress any existing case while fully fixing the absolute
filenames. I do not remember symlinks used in source trees so I consider
those only as a backward compatibility relict. And in this regard it can be
all further extended. Attachment to a C++ applications shows 26000 source
files from all its tens/hundreds libraries so using relative source filenames
is rather a pain. I already got hit by false breakpoint hits due to an
accidental source filename match.
> > So I do not understand why MS-Windows stat call does not provide st_ino from
> > those fields.
>
> Because MS didn't bother to code that.
BTW Free wine32 also has st_ino == 0; I understand it needs to be compatible.
Free wine64 (with 64-bit PE32+ executable) also behaves the same.
> That's why I suggested a separate method for retrieving the inode.
Thanks for the suggestion, it may match better (+it would be faster also on
MS-Windows) than the filename strings fallback.
Jan
next prev parent reply other threads:[~2013-01-22 8:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-17 21:59 Jan Kratochvil
2013-01-21 18:57 ` Tom Tromey
2013-01-21 21:11 ` Jan Kratochvil
2013-01-22 6:55 ` Eli Zaretskii
2013-01-22 7:12 ` Jan Kratochvil
2013-01-22 8:24 ` Eli Zaretskii
2013-01-22 8:47 ` Jan Kratochvil [this message]
2013-01-22 11:44 ` Eli Zaretskii
2013-01-22 12:05 ` Jan Kratochvil
2013-01-22 13:23 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130122084648.GA2790@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox