From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17757 invoked by alias); 22 Jan 2013 08:47:08 -0000 Received: (qmail 17748 invoked by uid 22791); 22 Jan 2013 08:47:07 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 Jan 2013 08:46:54 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0M8krYq016968 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 22 Jan 2013 03:46:53 -0500 Received: from host2.jankratochvil.net (ovpn-116-19.ams2.redhat.com [10.36.116.19]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r0M8kmCH002381 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 22 Jan 2013 03:46:51 -0500 Date: Tue, 22 Jan 2013 08:47:00 -0000 From: Jan Kratochvil To: Eli Zaretskii Cc: tromey@redhat.com, gdb-patches@sourceware.org Subject: Re: [patch 4/9] TUI: Use internally fullname Message-ID: <20130122084648.GA2790@host2.jankratochvil.net> References: <20130117215935.GE16249@host2.jankratochvil.net> <87r4le1i04.fsf@fleche.redhat.com> <20130121211121.GA29177@host2.jankratochvil.net> <83mww1ogfl.fsf@gnu.org> <20130122071205.GA31510@host2.jankratochvil.net> <83a9s1oc9w.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83a9s1oc9w.fsf@gnu.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00518.txt.bz2 On Tue, 22 Jan 2013 09:24:59 +0100, Eli Zaretskii wrote: > > But for NAME - the string which user entered in "break ./gdb.base/return.c:main" > > - has no compilation nor "current" directory. > > What is the semantics of such a 'break' command? Does "." here mean > the current directory? Or does it mean something else? It is compilation directory (DW_AT_comp_dir) relative name (therefore CU's DW_AT_name). Moreover recent GDBs allow to use also any trailing part, therefore not just "break ./gdb.base/return.c:main" and "break return.c:main" but also "break gdb.base/return.c". > If the former, then we have the current directory in GDB, don't we? Current directory of GDB can be somewhere completely else, it is not related. I just try not to regress any existing case while fully fixing the absolute filenames. I do not remember symlinks used in source trees so I consider those only as a backward compatibility relict. And in this regard it can be all further extended. Attachment to a C++ applications shows 26000 source files from all its tens/hundreds libraries so using relative source filenames is rather a pain. I already got hit by false breakpoint hits due to an accidental source filename match. > > So I do not understand why MS-Windows stat call does not provide st_ino from > > those fields. > > Because MS didn't bother to code that. BTW Free wine32 also has st_ino == 0; I understand it needs to be compatible. Free wine64 (with 64-bit PE32+ executable) also behaves the same. > That's why I suggested a separate method for retrieving the inode. Thanks for the suggestion, it may match better (+it would be faster also on MS-Windows) than the filename strings fallback. Jan