From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-97861-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 3448 invoked by alias); 21 Jan 2013 18:57:55 -0000
Received: (qmail 3423 invoked by uid 22791); 21 Jan 2013 18:57:54 -0000
X-SWARE-Spam-Status: No, hits=-6.5 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 21 Jan 2013 18:57:33 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0LIvXws010378	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Mon, 21 Jan 2013 13:57:33 -0500
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r0LIvVtZ028746	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Mon, 21 Jan 2013 13:57:32 -0500
From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch 4/9] TUI: Use internally fullname
References: <20130117215935.GE16249@host2.jankratochvil.net>
Date: Mon, 21 Jan 2013 18:57:00 -0000
In-Reply-To: <20130117215935.GE16249@host2.jankratochvil.net> (Jan	Kratochvil's message of "Thu, 17 Jan 2013 22:59:35 +0100")
Message-ID: <87r4le1i04.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.91 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2013-01/txt/msg00491.txt.bz2

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> TUI was using comp_dir-relative "filaname" during matching.

Looks good to me.

Jan> -		   && (filename_cmp (src->filename, loc->symtab->filename) == 0)
Jan> +		   && filename_cmp (src->fullname,
Jan> +				    symtab_to_fullname (loc->symtab)) == 0

After your patches is it ever ok to refer directly to symtab->filename?

Tom