From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org, Aleksandar Ristovski <ARistovski@qnx.com>
Subject: Re: [PATCH v5 6/8] gdbserver build-id attribute generator
Date: Tue, 20 May 2014 14:40:00 -0000 [thread overview]
Message-ID: <87ppj8tswu.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20140319223115.14668.73456.stgit@host1.jankratochvil.net> (Jan Kratochvil's message of "Wed, 19 Mar 2014 23:31:15 +0100")
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> producer part of the new "build-id" XML attribute.
I can't really claim to understand all of this patch.
What I do understand looks reasonable, and I'm prepared to approve it
given its history, etc.
However:
Jan> -<!ATTLIST library-list-svr4 version CDATA #FIXED "1.0">
Jan> -<!ATTLIST library-list-svr4 main-lm CDATA #IMPLIED>
Jan> +<!ATTLIST library-list-svr4 version CDATA #FIXED "1.0">
Jan> +<!ATTLIST library-list-svr4 main-lm CDATA #IMPLIED>
I am concerned about versioning of the XML.
Is it correct to keep the same version number?
If so -- why?
Perhaps we consider it compatible to add attributes.
I really don't know; nor did I find anything in the documentation.
So at the very least this needs an update to the manual to warn
future users.
Tom
next prev parent reply other threads:[~2014-05-20 14:40 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 23:12 [PATCH v5 0/8] Validate binary before use Jan Kratochvil
2014-03-19 22:30 ` [PATCH v5 1/8] Move utility functions to common/ Jan Kratochvil
2014-03-24 20:00 ` Sergio Durigan Junior
2014-05-18 19:05 ` Jan Kratochvil
2014-05-19 18:22 ` Tom Tromey
2014-05-19 22:48 ` Doug Evans
2014-05-19 22:46 ` Doug Evans
2014-05-19 18:21 ` Tom Tromey
2014-03-19 22:31 ` [PATCH v5 6/8] gdbserver build-id attribute generator Jan Kratochvil
2014-05-20 14:40 ` Tom Tromey [this message]
2014-05-21 12:24 ` Jan Kratochvil
2014-05-21 16:48 ` Tom Tromey
2014-03-19 22:31 ` [PATCH v5 8/8] Tests for validate symbol file using build-id Jan Kratochvil
2014-05-20 14:57 ` Tom Tromey
2014-05-20 15:29 ` Jan Kratochvil
2014-03-19 22:31 ` [PATCH v5 2/8] Merge multiple hex conversions Jan Kratochvil
2014-05-19 18:24 ` Tom Tromey
2014-03-19 22:31 ` [PATCH v5 3/8] Create empty common/linux-maps.[ch] and common/target-utils.[ch] Jan Kratochvil
2014-05-19 18:29 ` Tom Tromey
2014-03-19 22:31 ` [PATCH v5 7/8] Validate symbol file using build-id Jan Kratochvil
2014-03-20 3:51 ` Eli Zaretskii
2014-03-20 13:07 ` Jan Kratochvil
2014-03-20 17:28 ` Eli Zaretskii
2014-03-21 16:58 ` Jan Kratochvil
2014-03-20 13:13 ` Aleksandar Ristovski
2014-03-21 16:58 ` Jan Kratochvil
2014-03-21 17:08 ` Aleksandar Ristovski
2014-03-21 16:34 ` [PATCH v5 7/8] Validate symbol file using build-id [updated] Jan Kratochvil
2014-03-21 16:52 ` Eli Zaretskii
2014-05-20 14:51 ` [PATCH v5 7/8] Validate symbol file using build-id Tom Tromey
2014-03-19 22:31 ` [PATCH v5 4/8] Prepare linux_find_memory_regions_full & co. for move Jan Kratochvil
2014-05-19 19:15 ` Tom Tromey
2014-03-19 22:31 ` [PATCH v5 5/8] Move linux_find_memory_regions_full & co Jan Kratochvil
2014-05-19 19:19 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ppj8tswu.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=ARistovski@qnx.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox