From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23332 invoked by alias); 20 May 2014 14:40:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23322 invoked by uid 89); 20 May 2014 14:40:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 May 2014 14:40:46 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4KEebND018012 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 20 May 2014 10:40:39 -0400 Received: from barimba (ovpn-113-182.phx2.redhat.com [10.3.113.182]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s4KEeYJW006084 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Tue, 20 May 2014 10:40:36 -0400 From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org, Aleksandar Ristovski Subject: Re: [PATCH v5 6/8] gdbserver build-id attribute generator References: <20140319223004.14668.20989.stgit@host1.jankratochvil.net> <20140319223115.14668.73456.stgit@host1.jankratochvil.net> Date: Tue, 20 May 2014 14:40:00 -0000 In-Reply-To: <20140319223115.14668.73456.stgit@host1.jankratochvil.net> (Jan Kratochvil's message of "Wed, 19 Mar 2014 23:31:15 +0100") Message-ID: <87ppj8tswu.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-05/txt/msg00423.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> producer part of the new "build-id" XML attribute. I can't really claim to understand all of this patch. What I do understand looks reasonable, and I'm prepared to approve it given its history, etc. However: Jan> - Jan> - Jan> + Jan> + I am concerned about versioning of the XML. Is it correct to keep the same version number? If so -- why? Perhaps we consider it compatible to add attributes. I really don't know; nor did I find anything in the documentation. So at the very least this needs an update to the manual to warn future users. Tom