From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org, ARistovski@qnx.com
Subject: Re: [PATCH v5 7/8] Validate symbol file using build-id
Date: Thu, 20 Mar 2014 13:07:00 -0000 [thread overview]
Message-ID: <20140320073350.GA22555@host2.jankratochvil.net> (raw)
In-Reply-To: <83mwgl8r3n.fsf@gnu.org>
Hi Eli,
On Thu, 20 Mar 2014 04:51:40 +0100, Eli Zaretskii wrote:
> Thanks. I already approved the docs parts, right?
there remains unapproved the doc/gdb.texinfo part of this patch 7/8.
In this v5 series the text has been even changed due to the functionality
change:
* svr4_validate() considers missing local build-id as not-a-match
(*)
Unfinished discussion with you about this doc/gdb.texinfo part is:
https://sourceware.org/ml/gdb-patches/2014-03/msg00473.html
Message-ID: <20140319223258.GA5398@host2.jankratochvil.net>
Thanks,
Jan
(*) Originally I wanted to check it in mostly as Aleksandar wrote it with
various additions done possibly incrementally later.
But given how complicated is to settle down on the messages and
documentation of a part which was wrong (**) anyway I have decided to fix
it rather all already during this first check-in.
(**) wrong as not a regression but imperfect functionality.
I have found from practical using of non-upstreamed Fedora build-id
patches that it is never right to load non-build-id file for build-id
targer, in Fedora it is patch (not equivalent but similar functionality):
http://pkgs.fedoraproject.org/cgit/gdb.git/tree/gdb-6.6-buildid-locate-solib-missing-ids.patch
next prev parent reply other threads:[~2014-03-20 13:07 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 23:12 [PATCH v5 0/8] Validate binary before use Jan Kratochvil
2014-03-19 22:30 ` [PATCH v5 1/8] Move utility functions to common/ Jan Kratochvil
2014-03-24 20:00 ` Sergio Durigan Junior
2014-05-18 19:05 ` Jan Kratochvil
2014-05-19 18:22 ` Tom Tromey
2014-05-19 22:48 ` Doug Evans
2014-05-19 22:46 ` Doug Evans
2014-05-19 18:21 ` Tom Tromey
2014-03-19 22:31 ` [PATCH v5 6/8] gdbserver build-id attribute generator Jan Kratochvil
2014-05-20 14:40 ` Tom Tromey
2014-05-21 12:24 ` Jan Kratochvil
2014-05-21 16:48 ` Tom Tromey
2014-03-19 22:31 ` [PATCH v5 3/8] Create empty common/linux-maps.[ch] and common/target-utils.[ch] Jan Kratochvil
2014-05-19 18:29 ` Tom Tromey
2014-03-19 22:31 ` [PATCH v5 2/8] Merge multiple hex conversions Jan Kratochvil
2014-05-19 18:24 ` Tom Tromey
2014-03-19 22:31 ` [PATCH v5 8/8] Tests for validate symbol file using build-id Jan Kratochvil
2014-05-20 14:57 ` Tom Tromey
2014-05-20 15:29 ` Jan Kratochvil
2014-03-19 22:31 ` [PATCH v5 7/8] Validate " Jan Kratochvil
2014-03-20 3:51 ` Eli Zaretskii
2014-03-20 13:07 ` Jan Kratochvil [this message]
2014-03-20 17:28 ` Eli Zaretskii
2014-03-21 16:58 ` Jan Kratochvil
2014-03-20 13:13 ` Aleksandar Ristovski
2014-03-21 16:58 ` Jan Kratochvil
2014-03-21 17:08 ` Aleksandar Ristovski
2014-03-21 16:34 ` [PATCH v5 7/8] Validate symbol file using build-id [updated] Jan Kratochvil
2014-03-21 16:52 ` Eli Zaretskii
2014-05-20 14:51 ` [PATCH v5 7/8] Validate symbol file using build-id Tom Tromey
2014-03-19 22:31 ` [PATCH v5 4/8] Prepare linux_find_memory_regions_full & co. for move Jan Kratochvil
2014-05-19 19:15 ` Tom Tromey
2014-03-19 22:31 ` [PATCH v5 5/8] Move linux_find_memory_regions_full & co Jan Kratochvil
2014-05-19 19:19 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140320073350.GA22555@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=ARistovski@qnx.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox