From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9214 invoked by alias); 20 Mar 2014 13:07:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9204 invoked by uid 89); 20 Mar 2014 13:07:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 20 Mar 2014 13:07:18 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s2KD6cgB031718 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 20 Mar 2014 09:07:15 -0400 Received: from host2.jankratochvil.net (ovpn-116-22.ams2.redhat.com [10.36.116.22]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s2K7XrHl028480 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Thu, 20 Mar 2014 03:34:01 -0400 Date: Thu, 20 Mar 2014 13:07:00 -0000 From: Jan Kratochvil To: Eli Zaretskii Cc: gdb-patches@sourceware.org, ARistovski@qnx.com Subject: Re: [PATCH v5 7/8] Validate symbol file using build-id Message-ID: <20140320073350.GA22555@host2.jankratochvil.net> References: <20140319223004.14668.20989.stgit@host1.jankratochvil.net> <20140319223123.14668.95821.stgit@host1.jankratochvil.net> <83mwgl8r3n.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83mwgl8r3n.fsf@gnu.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2014-03/txt/msg00489.txt.bz2 Hi Eli, On Thu, 20 Mar 2014 04:51:40 +0100, Eli Zaretskii wrote: > Thanks. I already approved the docs parts, right? there remains unapproved the doc/gdb.texinfo part of this patch 7/8. In this v5 series the text has been even changed due to the functionality change: * svr4_validate() considers missing local build-id as not-a-match (*) Unfinished discussion with you about this doc/gdb.texinfo part is: https://sourceware.org/ml/gdb-patches/2014-03/msg00473.html Message-ID: <20140319223258.GA5398@host2.jankratochvil.net> Thanks, Jan (*) Originally I wanted to check it in mostly as Aleksandar wrote it with various additions done possibly incrementally later. But given how complicated is to settle down on the messages and documentation of a part which was wrong (**) anyway I have decided to fix it rather all already during this first check-in. (**) wrong as not a regression but imperfect functionality. I have found from practical using of non-upstreamed Fedora build-id patches that it is never right to load non-build-id file for build-id targer, in Fedora it is patch (not equivalent but similar functionality): http://pkgs.fedoraproject.org/cgit/gdb.git/tree/gdb-6.6-buildid-locate-solib-missing-ids.patch