Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org, Aleksandar Ristovski <ARistovski@qnx.com>
Subject: Re: [PATCH v5 6/8] gdbserver build-id attribute generator
Date: Wed, 21 May 2014 12:24:00 -0000	[thread overview]
Message-ID: <20140521122414.GA14744@host2.jankratochvil.net> (raw)
In-Reply-To: <87ppj8tswu.fsf@fleche.redhat.com>

On Tue, 20 May 2014 16:40:33 +0200, Tom Tromey wrote:
> >>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
> Jan> -<!ATTLIST library-list-svr4  version CDATA   #FIXED  "1.0">
> Jan> -<!ATTLIST library-list-svr4  main-lm CDATA   #IMPLIED>
> Jan> +<!ATTLIST library-list-svr4  version  CDATA   #FIXED  "1.0">
> Jan> +<!ATTLIST library-list-svr4  main-lm  CDATA   #IMPLIED>
> 
> I am concerned about versioning of the XML.
> Is it correct to keep the same version number?
> If so -- why?

I wrote a never replied essay + [patch] fix about why the current handling
of 'version' is wrong:
	[patch] gdbserver <library-list> and its #FIXED version="1.0"
	https://sourceware.org/ml/gdb-patches/2011-11/msg00099.html


> Perhaps we consider it compatible to add attributes.

Unrelated to the bug referenced above - I think so.


> I really don't know; nor did I find anything in the documentation.
> So at the very least this needs an update to the manual to warn
> future users.

I do not understand this.  The only changed (newly added) attribute is
build-id #IMPLIED - therefore optional - therefore backward/forward
compatible.  Who needs to be warned about it?


Regards,
Jan


  reply	other threads:[~2014-05-21 12:24 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-19 23:12 [PATCH v5 0/8] Validate binary before use Jan Kratochvil
2014-03-19 22:30 ` [PATCH v5 1/8] Move utility functions to common/ Jan Kratochvil
2014-03-24 20:00   ` Sergio Durigan Junior
2014-05-18 19:05     ` Jan Kratochvil
2014-05-19 18:22       ` Tom Tromey
2014-05-19 22:48         ` Doug Evans
2014-05-19 22:46       ` Doug Evans
2014-05-19 18:21   ` Tom Tromey
2014-03-19 22:31 ` [PATCH v5 4/8] Prepare linux_find_memory_regions_full & co. for move Jan Kratochvil
2014-05-19 19:15   ` Tom Tromey
2014-03-19 22:31 ` [PATCH v5 5/8] Move linux_find_memory_regions_full & co Jan Kratochvil
2014-05-19 19:19   ` Tom Tromey
2014-03-19 22:31 ` [PATCH v5 7/8] Validate symbol file using build-id Jan Kratochvil
2014-03-20  3:51   ` Eli Zaretskii
2014-03-20 13:07     ` Jan Kratochvil
2014-03-20 17:28       ` Eli Zaretskii
2014-03-21 16:58         ` Jan Kratochvil
2014-03-20 13:13   ` Aleksandar Ristovski
2014-03-21 16:58     ` Jan Kratochvil
2014-03-21 17:08       ` Aleksandar Ristovski
2014-03-21 16:34   ` [PATCH v5 7/8] Validate symbol file using build-id [updated] Jan Kratochvil
2014-03-21 16:52     ` Eli Zaretskii
2014-05-20 14:51   ` [PATCH v5 7/8] Validate symbol file using build-id Tom Tromey
2014-03-19 22:31 ` [PATCH v5 2/8] Merge multiple hex conversions Jan Kratochvil
2014-05-19 18:24   ` Tom Tromey
2014-03-19 22:31 ` [PATCH v5 8/8] Tests for validate symbol file using build-id Jan Kratochvil
2014-05-20 14:57   ` Tom Tromey
2014-05-20 15:29     ` Jan Kratochvil
2014-03-19 22:31 ` [PATCH v5 3/8] Create empty common/linux-maps.[ch] and common/target-utils.[ch] Jan Kratochvil
2014-05-19 18:29   ` Tom Tromey
2014-03-19 22:31 ` [PATCH v5 6/8] gdbserver build-id attribute generator Jan Kratochvil
2014-05-20 14:40   ` Tom Tromey
2014-05-21 12:24     ` Jan Kratochvil [this message]
2014-05-21 16:48       ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140521122414.GA14744@host2.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=ARistovski@qnx.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox