Re: [PATCH v5 6/8] gdbserver build-id attribute generator

Jan Kratochvil
2014-05-21T12:24:30Z

On Tue, 20 May 2014 16:40:33 +0200, Tom Tromey wrote:
> >>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
> Jan> -<!ATTLIST library-list-svr4 version CDATA #FIXED "1.0">
> Jan> -<!ATTLIST library-list-svr4 main-lm CDATA #IMPLIED>
> Jan> +<!ATTLIST library-list-svr4 version CDATA #FIXED "1.0">
> Jan> +<!ATTLIST library-list-svr4 main-lm CDATA #IMPLIED>
>
> I am concerned about versioning of the XML.
> Is it correct to keep the same version number?
> If so -- why?

I wrote a never replied essay + [patch] fix about why the current handling
of 'version' is wrong:
[patch] gdbserver <library-list> and its #FIXED version="1.0"
https://sourceware.org/ml/gdb-patches/2011-11/msg00099.html

> Perhaps we consider it compatible to add attributes.

Unrelated to the bug referenced above - I think so.

> I really don't know; nor did I find anything in the documentation.
> So at the very least this needs an update to the manual to warn
> future users.

I do not understand this. The only changed (newly added) attribute is
build-id #IMPLIED - therefore optional - therefore backward/forward
compatible. Who needs to be warned about it?

Regards,
Jan