From: Tom Tromey <tromey@redhat.com>
To: mbilal <mbilal@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [patch] patch for review of PR gdb/10462
Date: Tue, 16 Apr 2013 20:50:00 -0000 [thread overview]
Message-ID: <87li8i9yls.fsf@fleche.redhat.com> (raw)
In-Reply-To: <516D3B30.6080501@codesourcery.com> (mbilal@codesourcery.com's message of "Tue, 16 Apr 2013 16:51:12 +0500")
>>>>> ">" == mbilal <mbilal@codesourcery.com> writes:
>> please find attached, proposed patch for PR gdb/10462
>> that is, argument must be preceded by space.
>> + if (strlen(*line) != 0 && c->type == set_cmd && **line != ' ' )
Space after 'strlen' and no space before the ')'.
Also, it seems like isspace would be better here.
Finally, this could use a test case.
You can just add one to some relevant .exp file.
Tom
next prev parent reply other threads:[~2013-04-16 17:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-16 15:45 mbilal
2013-04-16 15:45 ` Abid, Hafiz
2013-04-16 20:50 ` Tom Tromey [this message]
2013-04-17 14:52 ` Andreas Schwab
2013-04-17 15:48 ` mbilal
2013-04-17 15:53 ` Abid, Hafiz
2013-04-17 16:06 ` Pedro Alves
2013-04-17 16:49 ` mbilal
2013-04-17 17:02 ` Pedro Alves
[not found] <516EB58F.2090603@codesourcery.com>
2013-04-17 17:25 ` mbilal
2013-04-17 20:34 ` Pedro Alves
2013-04-24 18:23 ` mbilal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87li8i9yls.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=mbilal@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox