Re: [patch] patch for review of PR gdb/10462

["Abid, Hafiz" <hafiz_abid@mentor.com>]

Hi Bilal,
Few small nits.

> +	PR gdb/10462
> +	* cli/cli-decode.c (lookup_command): Checked a space before  
> argument.
s/Checked/Check/
Also I think this can be a bit more descriptive like "Show an error if  
there is no space before argument."

> +      if (strlen(*line) != 0 && c->type == set_cmd && **line != ' ' )
A space here      ^.


Regards,
Abid
From gdb-patches-return-100552-listarch-gdb-patches=sources.redhat.com@sourceware.org Tue Apr 16 15:22:29 2013
Return-Path: <gdb-patches-return-100552-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Delivered-To: listarch-gdb-patches@sources.redhat.com
Received: (qmail 18416 invoked by alias); 16 Apr 2013 15:22:28 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Delivered-To: mailing list gdb-patches@sourceware.org
Received: (qmail 18407 invoked by uid 89); 16 Apr 2013 15:22:28 -0000
X-Spam-SWARE-Status: No, score=-8.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.1
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 16 Apr 2013 15:22:28 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3GFMQC6005768	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits%6 verify=OK)	for <gdb-patches@sourceware.org>; Tue, 16 Apr 2013 11:22:26 -0400
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r3GFMPT3027438;	Tue, 16 Apr 2013 11:22:26 -0400
Message-ID: <516D6CB1.8070201@redhat.com>
Date: Tue, 16 Apr 2013 15:45:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4
MIME-Version: 1.0
To: Tom Tromey <tromey@redhat.com>
CC: gdb-patches@sourceware.org
Subject: Re: RFC: fix PR gdb/15338
References: <87obdfbn8n.fsf@fleche.redhat.com> <516C5988.8070507@redhat.com> <87haj7bmgd.fsf@fleche.redhat.com> <8738uqbjcs.fsf@fleche.redhat.com>
In-Reply-To: <8738uqbjcs.fsf@fleche.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-SW-Source: 2013-04/txt/msg00478.txt.bz2
Content-length: 263

On 04/16/2013 04:12 PM, Tom Tromey wrote:
> Tom> There isn't one, but I can ask the reporter for it.
> Tom> I didn't ask earlier since I thought the problem was obvious from the
> Tom> assertion failure.
>
> There's one in the PR now.

Thanks.

--
Pedro Alves