From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29218 invoked by alias); 16 Apr 2013 12:18:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29208 invoked by uid 89); 16 Apr 2013 12:18:15 -0000 X-Spam-SWARE-Status: No, score=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 16 Apr 2013 12:18:14 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1US4px-0000gf-7q from Hafiz_Abid@mentor.com for gdb-patches@sourceware.org; Tue, 16 Apr 2013 05:18:13 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Tue, 16 Apr 2013 05:18:13 -0700 Received: from abidh-ubunto1104 (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server (TLS) id 14.1.289.1; Tue, 16 Apr 2013 13:18:11 +0100 Date: Tue, 16 Apr 2013 15:45:00 -0000 From: "Abid, Hafiz" Subject: Re: [patch] patch for review of PR gdb/10462 To: mbilal CC: In-Reply-To: <516D3B30.6080501@codesourcery.com> (from mbilal@codesourcery.com on Tue Apr 16 12:51:12 2013) Message-ID: <1366114689.4863.0@abidh-ubunto1104> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; delsp=Yes; format=Flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable X-SW-Source: 2013-04/txt/msg00473.txt.bz2 Hi Bilal, Few small nits. > + PR gdb/10462 > + * cli/cli-decode.c (lookup_command): Checked a space before=20=20 > argument. s/Checked/Check/ Also I think this can be a bit more descriptive like "Show an error if=20=20 there is no space before argument." > + if (strlen(*line) !=3D 0 && c->type =3D=3D set_cmd && **line !=3D = ' ' ) A space here ^. Regards, Abid >From gdb-patches-return-100552-listarch-gdb-patches=sources.redhat.com@sourceware.org Tue Apr 16 15:22:29 2013 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 18416 invoked by alias); 16 Apr 2013 15:22:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 18407 invoked by uid 89); 16 Apr 2013 15:22:28 -0000 X-Spam-SWARE-Status: No, score=-8.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 16 Apr 2013 15:22:28 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3GFMQC6005768 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 16 Apr 2013 11:22:26 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r3GFMPT3027438; Tue, 16 Apr 2013 11:22:26 -0400 Message-ID: <516D6CB1.8070201@redhat.com> Date: Tue, 16 Apr 2013 15:45:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: RFC: fix PR gdb/15338 References: <87obdfbn8n.fsf@fleche.redhat.com> <516C5988.8070507@redhat.com> <87haj7bmgd.fsf@fleche.redhat.com> <8738uqbjcs.fsf@fleche.redhat.com> In-Reply-To: <8738uqbjcs.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-04/txt/msg00478.txt.bz2 Content-length: 263 On 04/16/2013 04:12 PM, Tom Tromey wrote: > Tom> There isn't one, but I can ask the reporter for it. > Tom> I didn't ask earlier since I thought the problem was obvious from the > Tom> assertion failure. > > There's one in the PR now. Thanks. -- Pedro Alves