From: mbilal <mbilal@codesourcery.com>
To: <gdb-patches@sourceware.org>
Subject: [patch] patch for review of PR gdb/10462
Date: Tue, 16 Apr 2013 15:45:00 -0000 [thread overview]
Message-ID: <516D3B30.6080501@codesourcery.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 126 bytes --]
Hi,
please find attached, proposed patch for PR gdb/10462
that is, argument must be preceded by space.
Thanks,
-Bilal
[-- Attachment #2: Pr10462.diff --]
[-- Type: text/x-patch, Size: 1237 bytes --]
Index: cli/cli-decode.c
===================================================================
RCS file: /cvs/src/src/gdb/cli/cli-decode.c,v
retrieving revision 1.118
diff -u -p -r1.118 cli-decode.c
--- cli/cli-decode.c 10 Apr 2013 15:11:12 -0000 1.118
+++ cli/cli-decode.c 16 Apr 2013 11:49:40 -0000
@@ -1556,6 +1556,9 @@ lookup_cmd (const char **line, struct cm
}
else
{
+ if (strlen(*line) != 0 && c->type == set_cmd && **line != ' ' )
+ error (_("Argument must be preceded by space."));
+
/* We've got something. It may still not be what the caller
wants (if this command *needs* a subcommand). */
while (**line == ' ' || **line == '\t')
Index: ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/ChangeLog,v
retrieving revision 1.15421
diff -u -p -r1.15421 ChangeLog
--- ChangeLog 15 Apr 2013 23:53:37 -0000 1.15421
+++ ChangeLog 16 Apr 2013 11:45:38 -0000
@@ -1,3 +1,8 @@
+2013-04-16 Muhammad Bilal <mbilal@codesourcery.com>
+
+ PR gdb/10462
+ * cli/cli-decode.c (lookup_command): Checked a space before argument.
+
2013-04-15 Doug Evans <dje@google.com>
* dwarf2read.c (struct dwo_file): Replace member "cus" with "cu".
next reply other threads:[~2013-04-16 11:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-16 15:45 mbilal [this message]
2013-04-16 15:45 ` Abid, Hafiz
2013-04-16 20:50 ` Tom Tromey
2013-04-17 14:52 ` Andreas Schwab
2013-04-17 15:48 ` mbilal
2013-04-17 15:53 ` Abid, Hafiz
2013-04-17 16:06 ` Pedro Alves
2013-04-17 16:49 ` mbilal
2013-04-17 17:02 ` Pedro Alves
[not found] <516EB58F.2090603@codesourcery.com>
2013-04-17 17:25 ` mbilal
2013-04-17 20:34 ` Pedro Alves
2013-04-24 18:23 ` mbilal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516D3B30.6080501@codesourcery.com \
--to=mbilal@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox