From: Pedro Alves <palves@redhat.com>
To: mbilal <mbilal@codesourcery.com>
Cc: tromey@redhat.com, schwab@suse.de, hafiz_abid@mentor.com,
gdb-patches@sourceware.org
Subject: Re: [patch] patch for review of PR gdb/10462
Date: Wed, 17 Apr 2013 16:06:00 -0000 [thread overview]
Message-ID: <516E8152.5060709@redhat.com> (raw)
In-Reply-To: <516E67FE.5070301@codesourcery.com>
On 04/17/2013 10:14 AM, mbilal wrote:
> + if (**line != '\0' && c->type == set_cmd && !isspace (**line))
> + error (_("Argument must be preceded by space."));
How about putting the 'line' tests together?
if (c->type == set_cmd && **line != '\0' && !isspace (**line))
error (_("Argument must be preceded by space."));
As is looks a bit odd to me.
> +#test argument must be preceded by space
> +foreach x {"history file" "solib-search-path" "data-directory"} {
> + foreach y {"/home/" "." "~/home"} {
I think it'd be good to test the reported case of using = instead of space too.
> + gdb_test "set $x$y" "Argument must be preceded by space." "check space before argument"
http://sourceware.org/gdb/wiki/GDBTestcaseCookbook#Make_sure_test_messages_are_unique
> + gdb_test_no_output "set $x $y" "set $x $y"
> + }
> +}
--
Pedro Alves
next prev parent reply other threads:[~2013-04-17 11:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-16 15:45 mbilal
2013-04-16 15:45 ` Abid, Hafiz
2013-04-16 20:50 ` Tom Tromey
2013-04-17 14:52 ` Andreas Schwab
2013-04-17 15:48 ` mbilal
2013-04-17 15:53 ` Abid, Hafiz
2013-04-17 16:06 ` Pedro Alves [this message]
2013-04-17 16:49 ` mbilal
2013-04-17 17:02 ` Pedro Alves
[not found] <516EB58F.2090603@codesourcery.com>
2013-04-17 17:25 ` mbilal
2013-04-17 20:34 ` Pedro Alves
2013-04-24 18:23 ` mbilal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516E8152.5060709@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=hafiz_abid@mentor.com \
--cc=mbilal@codesourcery.com \
--cc=schwab@suse.de \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox