From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-100571-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 22776 invoked by alias); 16 Apr 2013 17:25:40 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 22767 invoked by uid 89); 16 Apr 2013 17:25:40 -0000
X-Spam-SWARE-Status: No, score=-6.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.1
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 16 Apr 2013 17:25:40 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3GHPb4p032371	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Tue, 16 Apr 2013 13:25:37 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r3GHPZGG017362	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Tue, 16 Apr 2013 13:25:36 -0400
From: Tom Tromey <tromey@redhat.com>
To: mbilal <mbilal@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [patch] patch for review of PR gdb/10462
References: <516D3B30.6080501@codesourcery.com>
Date: Tue, 16 Apr 2013 20:50:00 -0000
In-Reply-To: <516D3B30.6080501@codesourcery.com> (mbilal@codesourcery.com's	message of "Tue, 16 Apr 2013 16:51:12 +0500")
Message-ID: <87li8i9yls.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2013-04/txt/msg00497.txt.bz2

>>>>> ">" == mbilal  <mbilal@codesourcery.com> writes:

>> please find attached,  proposed patch for  PR gdb/10462
>> that is, argument must be  preceded by  space.

>> +      if (strlen(*line) != 0 && c->type == set_cmd && **line != ' ' )

Space after 'strlen' and no space before the ')'.
Also, it seems like isspace would be better here.

Finally, this could use a test case.
You can just add one to some relevant .exp file.

Tom