Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andreas Arnez <arnez@linux.vnet.ibm.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] s390-nat.c: Fix missing prototypes
Date: Tue, 06 Mar 2012 09:49:00 -0000	[thread overview]
Message-ID: <87ipiigiup.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <20120305190642.GJ2853@adacore.com> (Joel Brobecker's message of	"Mon, 5 Mar 2012 11:06:42 -0800")

Joel Brobecker <brobecker@adacore.com> writes:

>> Tested on s390x-ibm-linux with no regressions, fixes a
>> -Wmissing-prototypes build failure.
>> 
>> gdb/
>> 2012-03-05  Andreas Arnez  <arnez@linux.vnet.ibm.com>
>> 
>> 	* s390-nat.c: Include "gregset.h".
>
> Thanks! Attached is what I committed for you. I dropped the comment,
> since I felt it was completely redundant.

Thanks!  Dropping the comment is OK.  However, you also relocated the
include statement.  This doesn't work, because "gregset.h" uses a
typedef from the system header file <sys/ucontext.h>.  The order of
inclusion matters, and any other than my original patch may not work
either.

-- Andreas


  reply	other threads:[~2012-03-06  9:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-05 17:39 Andreas Arnez
2012-03-05 19:07 ` Joel Brobecker
2012-03-06  9:49   ` Andreas Arnez [this message]
2012-03-06 10:26     ` Pedro Alves
2012-03-06 11:35       ` Andreas Arnez
2012-03-06 11:52         ` Pedro Alves
2012-03-06 12:15           ` Andreas Arnez
2012-03-06 16:30             ` Joel Brobecker
2012-03-06 17:18               ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ipiigiup.fsf@linux.vnet.ibm.com \
    --to=arnez@linux.vnet.ibm.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox