From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19191 invoked by alias); 6 Mar 2012 09:49:30 -0000 Received: (qmail 19170 invoked by uid 22791); 6 Mar 2012 09:49:26 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from e06smtp17.uk.ibm.com (HELO e06smtp17.uk.ibm.com) (195.75.94.113) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 06 Mar 2012 09:49:13 +0000 Received: from /spool/local by e06smtp17.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 6 Mar 2012 09:49:11 -0000 Received: from d06nrmr1407.portsmouth.uk.ibm.com (9.149.38.185) by e06smtp17.uk.ibm.com (192.168.101.147) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 6 Mar 2012 09:49:03 -0000 Received: from d06av03.portsmouth.uk.ibm.com (d06av03.portsmouth.uk.ibm.com [9.149.37.213]) by d06nrmr1407.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q269n2pS2613314 for ; Tue, 6 Mar 2012 09:49:03 GMT Received: from d06av03.portsmouth.uk.ibm.com (localhost.localdomain [127.0.0.1]) by d06av03.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q269n2S3031065 for ; Tue, 6 Mar 2012 02:49:02 -0700 Received: from BR87Z6LW (dyn-9-152-212-27.boeblingen.de.ibm.com [9.152.212.27]) by d06av03.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id q269n2Rg031059; Tue, 6 Mar 2012 02:49:02 -0700 From: Andreas Arnez To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] s390-nat.c: Fix missing prototypes References: <8762ejrlqv.fsf@vnet.ibm.com> <20120305190642.GJ2853@adacore.com> Date: Tue, 06 Mar 2012 09:49:00 -0000 In-Reply-To: <20120305190642.GJ2853@adacore.com> (Joel Brobecker's message of "Mon, 5 Mar 2012 11:06:42 -0800") Message-ID: <87ipiigiup.fsf@linux.vnet.ibm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii x-cbid: 12030609-0542-0000-0000-0000012F2E70 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00179.txt.bz2 Joel Brobecker writes: >> Tested on s390x-ibm-linux with no regressions, fixes a >> -Wmissing-prototypes build failure. >> >> gdb/ >> 2012-03-05 Andreas Arnez >> >> * s390-nat.c: Include "gregset.h". > > Thanks! Attached is what I committed for you. I dropped the comment, > since I felt it was completely redundant. Thanks! Dropping the comment is OK. However, you also relocated the include statement. This doesn't work, because "gregset.h" uses a typedef from the system header file . The order of inclusion matters, and any other than my original patch may not work either. -- Andreas