Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Andreas Arnez <arnez@vnet.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] s390-nat.c: Fix missing prototypes
Date: Mon, 05 Mar 2012 19:07:00 -0000	[thread overview]
Message-ID: <20120305190642.GJ2853@adacore.com> (raw)
In-Reply-To: <8762ejrlqv.fsf@vnet.ibm.com>

[-- Attachment #1: Type: text/plain, Size: 324 bytes --]

> Tested on s390x-ibm-linux with no regressions, fixes a
> -Wmissing-prototypes build failure.
> 
> gdb/
> 2012-03-05  Andreas Arnez  <arnez@linux.vnet.ibm.com>
> 
> 	* s390-nat.c: Include "gregset.h".

Thanks! Attached is what I committed for you. I dropped the comment,
since I felt it was completely redundant.

-- 
Joel

[-- Attachment #2: 0001-Include-gregset.h-in-s390-nat.c-Wmissing-prototypes.patch --]
[-- Type: text/x-diff, Size: 1067 bytes --]

From 1063f42f816c3877e5e0ebdcd4500a7ec0c2820f Mon Sep 17 00:00:00 2001
From: Joel Brobecker <brobecker@adacore.com>
Date: Mon, 5 Mar 2012 11:04:04 -0800
Subject: [PATCH] Include "gregset.h" in s390-nat.c (-Wmissing-prototypes).

gdb/ChangeLog:

        * s390-nat.c: Include "gregset.h".
---
 gdb/ChangeLog  |    5 +++++
 gdb/s390-nat.c |    1 +
 2 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 2da944d..c2d0c59 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2012-03-05  Joel Brobecker  <brobecker@adacore.com>
+
+	From Andreas Arnez  <arnez@linux.vnet.ibm.com>:
+	* s390-nat.c: Include "gregset.h".
+
 2012-03-05  Jan Kratochvil  <jan.kratochvil@redhat.com>
 
 	* libunwind-frame.c (LIBUNWIND_SO): Change .7 to .8.
diff --git a/gdb/s390-nat.c b/gdb/s390-nat.c
index 2755e58..bad1b43 100644
--- a/gdb/s390-nat.c
+++ b/gdb/s390-nat.c
@@ -26,6 +26,7 @@
 #include "target.h"
 #include "linux-nat.h"
 #include "auxv.h"
+#include "gregset.h"
 
 #include "s390-tdep.h"
 #include "elf/common.h"
-- 
1.7.1


  reply	other threads:[~2012-03-05 19:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-05 17:39 Andreas Arnez
2012-03-05 19:07 ` Joel Brobecker [this message]
2012-03-06  9:49   ` Andreas Arnez
2012-03-06 10:26     ` Pedro Alves
2012-03-06 11:35       ` Andreas Arnez
2012-03-06 11:52         ` Pedro Alves
2012-03-06 12:15           ` Andreas Arnez
2012-03-06 16:30             ` Joel Brobecker
2012-03-06 17:18               ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120305190642.GJ2853@adacore.com \
    --to=brobecker@adacore.com \
    --cc=arnez@vnet.ibm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox