From: Andreas Arnez <arnez@linux.vnet.ibm.com>
To: Pedro Alves <palves@redhat.com>
Cc: Joel Brobecker <brobecker@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] s390-nat.c: Fix missing prototypes
Date: Tue, 06 Mar 2012 11:35:00 -0000 [thread overview]
Message-ID: <8762eigdxh.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <4F55E636.8040501@redhat.com> (Pedro Alves's message of "Tue, 06 Mar 2012 10:25:58 +0000")
Pedro Alves <palves@redhat.com> writes:
> Every other linux arch I looked at included <sys/procfs.h> before
> gregset.h instead (or gdb_proc_service.h, which pulls sys/procfs.h).
> Even core-regset.c does:
>
> #ifdef HAVE_SYS_PROCFS_H
> #include <sys/procfs.h>
> #endif
>
> /* Prototypes for supply_gregset etc. */
> #include "gregset.h"
> ...
>
> Are s390's headers different in this regard?
Including <sys/procfs.h> would work for s390 as well. Except for
pulling in some more declarations than <sys/ucontext.h>, there should be
no difference.
> I think we should consider putting
>
> #ifdef HAVE_SYS_PROCFS_H
> #include <sys/procfs.h>
> #endif
>
> in gregset.h itself.
Right, that sounds OK. Then Joel's commit for s390-nat.c could be left
as is.
-- Andreas
next prev parent reply other threads:[~2012-03-06 11:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-05 17:39 Andreas Arnez
2012-03-05 19:07 ` Joel Brobecker
2012-03-06 9:49 ` Andreas Arnez
2012-03-06 10:26 ` Pedro Alves
2012-03-06 11:35 ` Andreas Arnez [this message]
2012-03-06 11:52 ` Pedro Alves
2012-03-06 12:15 ` Andreas Arnez
2012-03-06 16:30 ` Joel Brobecker
2012-03-06 17:18 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8762eigdxh.fsf@linux.vnet.ibm.com \
--to=arnez@linux.vnet.ibm.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox