Re: [PATCH] s390-nat.c: Fix missing prototypes

[Pedro Alves <palves@redhat.com>]

On 03/06/2012 11:35 AM, Andreas Arnez wrote:

>> I think we should consider putting
>>
>> #ifdef HAVE_SYS_PROCFS_H
>> #include <sys/procfs.h>
>> #endif
>>
>> in gregset.h itself.
> 
> Right, that sounds OK.  Then Joel's commit for s390-nat.c could be left
> as is.


Builds fine on x64-64 Fedora, even when I move the gregset.h include in
amd64-linux-nat.c to the top, right below defs.h, like:

--- c/gdb/amd64-linux-nat.c
+++ w/gdb/amd64-linux-nat.c
@@ -19,6 +19,7 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */

 #include "defs.h"
+#include "gregset.h"
 #include "inferior.h"
 #include "gdbcore.h"
 #include "regcache.h"
@@ -46,9 +47,6 @@
 #include <sys/reg.h>
 #include "gdb_proc_service.h"

-/* Prototypes for supply_gregset etc.  */
-#include "gregset.h"
-
 #include "amd64-tdep.h"
 #include "i386-linux-tdep.h"
 #include "amd64-nat.h"

(which fails to build without the patch below)

Comments, anyone?

2012-03-06  Pedro Alves  <palves@redhat.com>

	* gregset.h [HAVE_SYS_PROCFS_H]: Include <sys/procfs.h>.

---

 gdb/gregset.h |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/gdb/gregset.h b/gdb/gregset.h
index 4f34788..d73b5b8 100644
--- a/gdb/gregset.h
+++ b/gdb/gregset.h
@@ -19,6 +19,10 @@
 #ifndef GREGSET_H
 #define GREGSET_H

+#ifdef HAVE_SYS_PROCFS_H
+#include <sys/procfs.h>
+#endif
+
 #ifndef GDB_GREGSET_T
 #define GDB_GREGSET_T gregset_t
 #endif