From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15597 invoked by alias); 6 Mar 2012 11:35:44 -0000 Received: (qmail 15402 invoked by uid 22791); 6 Mar 2012 11:35:43 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from e06smtp11.uk.ibm.com (HELO e06smtp11.uk.ibm.com) (195.75.94.107) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 06 Mar 2012 11:35:28 +0000 Received: from /spool/local by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 6 Mar 2012 11:35:26 -0000 Received: from d06nrmr1507.portsmouth.uk.ibm.com (9.149.38.233) by e06smtp11.uk.ibm.com (192.168.101.141) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 6 Mar 2012 11:35:24 -0000 Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com [9.149.37.217]) by d06nrmr1507.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q26BZOXk2470026 for ; Tue, 6 Mar 2012 11:35:24 GMT Received: from d06av06.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q26BZNOR012672 for ; Tue, 6 Mar 2012 04:35:23 -0700 Received: from BR87Z6LW (dyn-9-152-212-27.boeblingen.de.ibm.com [9.152.212.27]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id q26BZMwl012652; Tue, 6 Mar 2012 04:35:23 -0700 From: Andreas Arnez To: Pedro Alves Cc: Joel Brobecker , gdb-patches@sourceware.org Subject: Re: [PATCH] s390-nat.c: Fix missing prototypes References: <8762ejrlqv.fsf@vnet.ibm.com> <20120305190642.GJ2853@adacore.com> <87ipiigiup.fsf@linux.vnet.ibm.com> <4F55E636.8040501@redhat.com> Date: Tue, 06 Mar 2012 11:35:00 -0000 In-Reply-To: <4F55E636.8040501@redhat.com> (Pedro Alves's message of "Tue, 06 Mar 2012 10:25:58 +0000") Message-ID: <8762eigdxh.fsf@linux.vnet.ibm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii x-cbid: 12030611-5024-0000-0000-000001E5E795 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00185.txt.bz2 Pedro Alves writes: > Every other linux arch I looked at included before > gregset.h instead (or gdb_proc_service.h, which pulls sys/procfs.h). > Even core-regset.c does: > > #ifdef HAVE_SYS_PROCFS_H > #include > #endif > > /* Prototypes for supply_gregset etc. */ > #include "gregset.h" > ... > > Are s390's headers different in this regard? Including would work for s390 as well. Except for pulling in some more declarations than , there should be no difference. > I think we should consider putting > > #ifdef HAVE_SYS_PROCFS_H > #include > #endif > > in gregset.h itself. Right, that sounds OK. Then Joel's commit for s390-nat.c could be left as is. -- Andreas