From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 06/13] fix up gdb.mi
Date: Thu, 17 Oct 2013 18:45:00 -0000 [thread overview]
Message-ID: <87eh7jviqw.fsf@fleche.redhat.com> (raw)
In-Reply-To: <52196299.5050004@codesourcery.com> (Yao Qi's message of "Sun, 25 Aug 2013 09:49:13 +0800")
>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
>> # No notification is emitted for 'maint set' commands.
>> foreach boolean_opt { "on" "off" } {
>> - mi_gdb_test "maint set profile ${boolean_opt}" \
>> - "\\&\"maint set profile ${boolean_opt}\\\\n\"\r\n\\^done" \
>> - "\"maint set profile ${boolean_opt}\""
>> + mi_gdb_test "maint set dwarf2 always-disassemble ${boolean_opt}" \
>> + "\\&\"maint set dwarf2 always-disassemble
>> ${boolean_opt}\\\\n\"\r\n\\^done" \
>> + "\"maint dwarf2 always-disassemble ${boolean_opt}\""
>> }
Yao> We replace "maint set profile" with "maint set dwarf2
Yao> always-disassemble", because the former will cause gdb to generate a
Yao> file on exit?
Yes. The choice of command is incidental to the test, and this change
avoids the appearance of parallel-unsafe-ness.
>>
>> proc test_file_transfer { filename description } {
>> - mi_gdb_test "-target-file-put \"$filename\" \"down-server\"" \
>> + if {![is_remote host] && ![is_remote target]} {
>> + set up_server [standard_output_file up-server]
>> + set down_server [standard_output_file down-server]
>> + } else {
>> + set up_server up-server
>> + set down_server down-server
>> + }
>> +
Yao> IWBN to write comments, IMO.
Done now, thanks.
Tom
next prev parent reply other threads:[~2013-10-17 18:45 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 20:36 [PATCH 00/13] test suite parallel safety Tom Tromey
2013-08-23 20:36 ` [PATCH 04/13] fix up gdb.gdb Tom Tromey
2013-08-23 20:36 ` [PATCH 06/13] fix up gdb.mi Tom Tromey
2013-08-25 1:50 ` Yao Qi
2013-10-17 18:45 ` Tom Tromey [this message]
2013-08-23 20:37 ` [PATCH 09/13] update checkpoint test Tom Tromey
2013-08-23 20:37 ` [PATCH 05/13] fix up gdb.xml Tom Tromey
2013-08-27 12:12 ` Pedro Alves
2013-10-17 18:42 ` Tom Tromey
2013-10-18 15:20 ` Pedro Alves
2013-08-23 20:37 ` [PATCH 02/13] fix some simple thinkos in the test suite Tom Tromey
2013-08-23 20:37 ` [PATCH 13/13] make gdb.asm parallel-safe Tom Tromey
2013-08-27 13:48 ` Pedro Alves
2013-08-27 14:06 ` Tom Tromey
2013-08-23 20:37 ` [PATCH 01/13] fix up log-file toggling Tom Tromey
2013-08-23 20:37 ` [PATCH 10/13] update fileio test Tom Tromey
2013-08-23 20:37 ` [PATCH 03/13] fix weird.exp for parallel testing Tom Tromey
2013-08-23 20:37 ` [PATCH 08/13] simple changes in gdb.base Tom Tromey
2013-08-27 13:31 ` Pedro Alves
2013-10-17 19:58 ` Tom Tromey
2013-08-23 20:37 ` [PATCH 12/13] fix up gdb.server Tom Tromey
2013-08-23 20:37 ` [PATCH 11/13] introduce relative_filename and use it Tom Tromey
2013-08-27 13:44 ` Pedro Alves
2013-10-17 18:59 ` Tom Tromey
2013-08-23 20:37 ` [PATCH 07/13] fix up gdb.trace Tom Tromey
2013-08-27 12:26 ` Pedro Alves
2013-10-17 18:56 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eh7jviqw.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox